Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1203)

Side by Side Diff: components/metrics/file_metrics_provider_unittest.cc

Issue 1537743006: Persist setup metrics and have Chrome report them during UMA upload. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@shared-histograms
Patch Set: fixed test Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "components/metrics/file_metrics_provider.h"
6
7 #include "base/files/file_util.h"
8 #include "base/files/memory_mapped_file.h"
9 #include "base/files/scoped_temp_dir.h"
10 #include "base/metrics/histogram.h"
11 #include "base/metrics/histogram_flattener.h"
12 #include "base/metrics/histogram_persistence.h"
13 #include "base/metrics/histogram_snapshot_manager.h"
14 #include "base/metrics/persistent_memory_allocator.h"
15 #include "base/test/test_simple_task_runner.h"
16 #include "base/thread_task_runner_handle.h"
17 #include "components/metrics/metrics_pref_names.h"
18 #include "components/prefs/pref_registry_simple.h"
19 #include "components/prefs/testing_pref_service.h"
20 #include "testing/gtest/include/gtest/gtest.h"
21
22 using namespace base;
23
24 namespace {
25 const char kMetricsName[] = "TestMetrics";
26 const char kMetricsFilename[] = "file.metrics";
27 } // namespace
28
29 namespace metrics {
30
31 class HistogramFlattenerDeltaRecorder : public HistogramFlattener {
32 public:
33 HistogramFlattenerDeltaRecorder() {}
34
35 void RecordDelta(const HistogramBase& histogram,
36 const HistogramSamples& snapshot) override {
37 recorded_delta_histogram_names_.push_back(histogram.histogram_name());
38 }
39
40 void InconsistencyDetected(HistogramBase::Inconsistency problem) override {
41 ASSERT_TRUE(false);
42 }
43
44 void UniqueInconsistencyDetected(
45 HistogramBase::Inconsistency problem) override {
46 ASSERT_TRUE(false);
47 }
48
49 void InconsistencyDetectedInLoggedCount(int amount) override {
50 ASSERT_TRUE(false);
51 }
52
53 std::vector<std::string> GetRecordedDeltaHistogramNames() {
54 return recorded_delta_histogram_names_;
55 }
56
57 private:
58 std::vector<std::string> recorded_delta_histogram_names_;
59
60 DISALLOW_COPY_AND_ASSIGN(HistogramFlattenerDeltaRecorder);
61 };
62
63 class FileMetricsProviderTest : public testing::Test {
64 protected:
65 FileMetricsProviderTest()
66 : task_runner_(new TestSimpleTaskRunner()),
67 reply_runner_(task_runner_),
68 prefs_(new TestingPrefServiceSimple) {
69 EXPECT_TRUE(temp_dir_.CreateUniqueTempDir());
70 FileMetricsProvider::RegisterPrefs(prefs_->registry(), kMetricsName);
71 }
72
73 TestingPrefServiceSimple* prefs() { return prefs_.get(); }
74 FilePath temp_dir() { return temp_dir_.path(); }
75 FilePath metrics_file() {
76 return temp_dir_.path().AppendASCII(kMetricsFilename);
77 }
78
79 FileMetricsProvider* provider() {
80 if (!provider_)
81 provider_.reset(new FileMetricsProvider(task_runner_, prefs()));
82 return provider_.get();
83 }
84
85 void RunTasks() {
86 task_runner_->RunUntilIdle();
87 }
88
89 private:
90 scoped_refptr<TestSimpleTaskRunner> task_runner_;
91 ThreadTaskRunnerHandle reply_runner_;
92
93 ScopedTempDir temp_dir_;
94 scoped_ptr<TestingPrefServiceSimple> prefs_;
95 scoped_ptr<FileMetricsProvider> provider_;
96
97 DISALLOW_COPY_AND_ASSIGN(FileMetricsProviderTest);
98 };
99
100
101 TEST_F(FileMetricsProviderTest, AccessMetrics) {
102 ASSERT_FALSE(PathExists(metrics_file()));
103
104 {
105 // Get this first so it isn't created inside the persistent allocator.
106 GetCreateHistogramResultHistogram();
107
108 SetPersistentHistogramMemoryAllocator(
109 new LocalPersistentMemoryAllocator(64 << 10, 0, kMetricsName));
110 HistogramBase* foo = Histogram::FactoryGet("foo", 1, 100, 10, 0);
111 HistogramBase* bar = Histogram::FactoryGet("bar", 1, 100, 10, 0);
112 foo->Add(42);
113 bar->Add(84);
114
115 scoped_ptr<PersistentMemoryAllocator> allocator(
116 ReleasePersistentHistogramMemoryAllocator());
117 File writer(metrics_file(), File::FLAG_CREATE | File::FLAG_WRITE);
118 EXPECT_TRUE(writer.IsValid());
119 writer.Write(0, (const char*)allocator->data(), allocator->used());
120 }
121
122 // Register the file and allow the "checker" task to run.
123 ASSERT_TRUE(PathExists(metrics_file()));
124 provider()->RegisterFile(metrics_file(),
125 FileMetricsProvider::FILE_HISTOGRAMS_ATOMIC,
126 kMetricsName);
127
128 // Record embedded snapshots via snapshot-manager.
129 provider()->OnDidCreateMetricsLog();
130 RunTasks();
131 {
132 HistogramFlattenerDeltaRecorder flattener;
133 HistogramSnapshotManager snapshot_manager(&flattener);
134 snapshot_manager.StartDeltas();
135 provider()->RecordHistogramSnapshots(&snapshot_manager);
136 snapshot_manager.FinishDeltas();
137 EXPECT_EQ(2, flattener.GetRecordedDeltaHistogramNames().size());
138 }
139
140 // Second run on the same file should produce nothing.
141 provider()->OnDidCreateMetricsLog();
142 RunTasks();
143 {
144 HistogramFlattenerDeltaRecorder flattener;
145 HistogramSnapshotManager snapshot_manager(&flattener);
146 snapshot_manager.StartDeltas();
147 provider()->RecordHistogramSnapshots(&snapshot_manager);
148 snapshot_manager.FinishDeltas();
149 EXPECT_EQ(0, flattener.GetRecordedDeltaHistogramNames().size());
150 }
151 }
152
153 } // namespace metrics
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698