Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Side by Side Diff: chrome/installer/setup/installer_metrics.h

Issue 1537743006: Persist setup metrics and have Chrome report them during UMA upload. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@shared-histograms
Patch Set: address (many) comments by Greg Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright (c) 2016 The Chromium Authors. All rights reserved.
grt (UTC plus 2) 2016/02/08 18:09:19 nit: no (c) in copyright notices for new files (ht
bcwhite 2016/02/09 21:08:46 Done.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #ifndef CHROME_INSTALLER_SETUP_INSTALLER_METRICS_H_
6 #define CHROME_INSTALLER_SETUP_INSTALLER_METRICS_H_
7
8 namespace base {
9 class FilePath;
10 } // namespace base
11
12 namespace installer {
13
14 // Create a persistent space for any histograms that can be reported later
grt (UTC plus 2) 2016/02/08 18:09:19 nit: "Creates..." as per https://google.github.io/
bcwhite 2016/02/09 21:08:46 Done.
15 // by the browser process.
16 void BeginPersistentHistogramStorage(const char* name);
17
18 // Save all the persistent histograms to a single file on disk for reading
grt (UTC plus 2) 2016/02/08 18:09:19 nit: "Saves..."
bcwhite 2016/02/09 21:08:46 Done.
19 // by the browser so it can be reported.
20 void EndPersistentHistogramStorage(const base::FilePath& target_dir);
21
22 } // namespace installer
23
24 #endif // CHROME_INSTALLER_SETUP_INSTALLER_METRICS_H_
25
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698