unittest/AssemblerX8664/TestUtil.h - Issue 1537703002: Subzero. x8664. Resurrects the Target.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: unittest/AssemblerX8664/TestUtil.h

Issue 1537703002: Subzero. x8664. Resurrects the Target. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Addresses comments. Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: unittest/AssemblerX8664/TestUtil.h

diff --git a/unittest/AssemblerX8664/TestUtil.h b/unittest/AssemblerX8664/TestUtil.h

index 455fe9c8c5b469b123dbb3928c3cc4e20cc07156..2f3b0709481a1aa0a367f768ab8904dee09a0513 100644

--- a/unittest/AssemblerX8664/TestUtil.h

+++ b/unittest/AssemblerX8664/TestUtil.h

@@ -701,7 +701,7 @@ protected:

EXPECT_LT(MySize, MaxCodeSize);

assert(MySize < MaximumCodeSize);

ExecutableData = mmap(nullptr, Size, PROT_WRITE | PROT_READ | PROT_EXEC,

- MAP_PRIVATE | MAP_ANONYMOUS, -1, 0);

+ MAP_PRIVATE | MAP_ANONYMOUS | MAP_32BIT, -1, 0);

EXPECT_NE(MAP_FAILED, ExecutableData) << strerror(errno);

assert(MAP_FAILED != ExecutableData);

std::memcpy(ExecutableData, Data, MySize);

« src/IceTargetLoweringX8632Traits.h ('K') | « unittest/AssemblerX8664/LowLevel.cpp ('k') | no next file » | no next file with comments »