dart2js: Initial implementation of inlining.

pkg/compiler/lib/src/cps_ir/cps_ir_nodes_sexpr.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library dart2js.ir_nodes_sexpr;
 
 import '../constants/values.dart';
 import '../util/util.dart';
 import 'cps_ir_nodes.dart';
 import '../universe/call_structure.dart' show
@@ skipping 30 matching lines @@
     return namer.nameParameter(node);
   }
 
   String visitMutableVariable(MutableVariable node) {
     return namer.nameMutableVariable(node);
   }
 
   /// Main entry point for creating a [String] from a [Node].  All recursive
   /// calls must go through this method.
   String visit(Node node) {
+    if (node == null) return '**** NULL ****';
     String s = node.accept(this);
     return decorator(node, s);
   }
 
   String formatThisParameter(Parameter thisParameter) {
     return thisParameter == null ? '()' : '(${visit(thisParameter)})';
   }
 
   String visitFunctionDefinition(FunctionDefinition node) {
     String name = node.element.name;
@@ skipping 44 matching lines @@
   }
 
   String visitLetMutable(LetMutable node) {
     String name = visit(node.variable);
     String value = access(node.value);
     String body = indentBlock(() => visit(node.body));
     return '$indentation(LetMutable ($name $value)\n$body)';
   }
 
   String formatArguments(CallStructure call,
-        List<Reference<Primitive>> arguments,
-        [CallingConvention callingConvention = CallingConvention.Normal]) {
+      List<Reference<Primitive>> arguments,
+      [CallingConvention callingConvention = CallingConvention.Normal]) {
     int positionalArgumentCount = call.positionalArgumentCount;
-    if (callingConvention == CallingConvention.Intercepted) {
+    if (callingConvention != CallingConvention.Normal) {

[asgerf, 2015/12/17 15:40:34]

Could you add an exception for the new OneShotIntercepted calling convention? It
should behave like the Normal convention.

[Kevin Millikin (Google), 2015/12/21 12:28:02]

Done.

       ++positionalArgumentCount;
     }
     List<String> args =
-        arguments.getRange(0, positionalArgumentCount).map(access).toList();
+        arguments.take(positionalArgumentCount).map(access).toList();
     List<String> argumentNames = call.getOrderedNamedArguments();
     for (int i = 0; i < argumentNames.length; ++i) {
       String name = argumentNames[i];
       String arg = access(arguments[positionalArgumentCount + i]);
       args.add("($name: $arg)");
     }
+    // Constructors can have type parameter after the named arguments.
+    args.addAll(
+        arguments.skip(positionalArgumentCount + argumentNames.length)
+            .map(access));
     return '(${args.join(' ')})';
   }
 
   String visitInvokeStatic(InvokeStatic node) {
     String name = node.target.name;
     String args = formatArguments(node.selector.callStructure, node.arguments);
     return '(InvokeStatic $name $args)';
   }
 
   String visitInvokeMethod(InvokeMethod node) {
@@ skipping 24 matching lines @@
       name = '${name}.${node.target.name}';
     }
     String args = formatArguments(node.selector.callStructure, node.arguments);
     return '(InvokeConstructor $name $args)';
   }
 
   String visitInvokeContinuation(InvokeContinuation node) {
     String name = access(node.continuation);
     if (node.isRecursive) name = 'rec $name';
     String args = node.arguments.map(access).join(' ');
-    return '$indentation(InvokeContinuation $name ($args))';
+    String escaping = node.isEscapingTry ? ' escape' : '';
+    return '$indentation(InvokeContinuation $name ($args)$escaping)';
   }
 
   String visitThrow(Throw node) {
     String value = access(node.value);
     return '$indentation(Throw $value)';
   }
 
   String visitRethrow(Rethrow node) {
     return '$indentation(Rethrow)';
   }
@@ skipping 300 matching lines @@
   void setReturnContinuation(Continuation node) {
     assert(!_names.containsKey(node) || _names[node] == 'return');
     _names[node] = 'return';
   }
 
   String getName(Node node) {
     if (!_names.containsKey(node)) return 'MISSING_NAME';
     return _names[node];
   }
 }