Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1537643002: Add --enable-wasm to wasm tests. (Closed)

Created:
5 years ago by bradn
Modified:
5 years ago
Reviewers:
ahaas
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add --enable-wasm to wasm tests. In preparation for switching wasm from a compile to a runtime option, add the runtime flag to all mjsunit tests. R=ahaas@chromium.org BUG= Committed: https://crrev.com/98d4fbfb2dd343da91eb258d1665bfcd93ebf110 Cr-Commit-Position: refs/heads/master@{#32938}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -3 lines) Patch
M test/mjsunit/wasm/asm-wasm.js View 1 chunk +2 lines, -0 lines 0 comments Download
M test/mjsunit/wasm/calls.js View 1 chunk +2 lines, -0 lines 0 comments Download
M test/mjsunit/wasm/compile-run-basic.js View 1 chunk +2 lines, -0 lines 0 comments Download
M test/mjsunit/wasm/divrem-trap.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/wasm/ffi.js View 1 chunk +2 lines, -0 lines 0 comments Download
M test/mjsunit/wasm/ffi-error.js View 1 chunk +2 lines, -0 lines 0 comments Download
M test/mjsunit/wasm/indirect-calls.js View 1 chunk +2 lines, -0 lines 0 comments Download
M test/mjsunit/wasm/instantiate-module-basic.js View 1 chunk +2 lines, -0 lines 0 comments Download
M test/mjsunit/wasm/module-memory.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/wasm/params.js View 1 chunk +2 lines, -0 lines 0 comments Download
M test/mjsunit/wasm/stackwalk.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/wasm/unreachable.js View 1 chunk +2 lines, -0 lines 0 comments Download
M test/mjsunit/wasm/verify-function-basic-errors.js View 1 chunk +2 lines, -0 lines 0 comments Download
M test/mjsunit/wasm/verify-function-simple.js View 1 chunk +2 lines, -0 lines 0 comments Download
M test/mjsunit/wasm/verify-module-basic-errors.js View 1 chunk +2 lines, -0 lines 0 comments Download
M test/mjsunit/wasm/wasm-constants.js View 1 chunk +2 lines, -0 lines 0 comments Download
M test/mjsunit/wasm/wasm-object-api.js View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
bradn
5 years ago (2015-12-17 10:34:27 UTC) #1
ahaas
lgtm
5 years ago (2015-12-17 10:37:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1537643002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1537643002/1
5 years ago (2015-12-17 10:39:55 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-17 10:54:12 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/98d4fbfb2dd343da91eb258d1665bfcd93ebf110 Cr-Commit-Position: refs/heads/master@{#32938}
5 years ago (2015-12-17 10:55:00 UTC) #7
dougc
On 2015/12/17 10:55:00, commit-bot: I haz the power wrote: > Patchset 1 (id:??) landed as ...
5 years ago (2015-12-17 13:42:21 UTC) #8
dougc
On 2015/12/17 13:42:21, dougc wrote: > On 2015/12/17 10:55:00, commit-bot: I haz the power wrote: ...
5 years ago (2015-12-17 13:42:59 UTC) #9
bradn
5 years ago (2015-12-17 13:46:10 UTC) #10
Message was sent while issue was closed. 
Oops, excellent point.

Powered by Google App Engine
This is Rietveld 408576698