mojo/services/geometry/cpp/BUILD.gn - Issue 1537633005: Extend the geometry APIs.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: mojo/services/geometry/cpp/BUILD.gn

Issue 1537633005: Extend the geometry APIs. (Closed) Base URL: git@github.com:domokit/mojo.git@moz-10

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « mojo/dart/packages/mojo_services/lib/mojo/geometry.mojom.dart ('k') | mojo/services/geometry/cpp/geometry_util.h » ('j') | mojo/services/geometry/cpp/geometry_util.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 # Copyright 2014 The Chromium Authors. All rights reserved.	1 # Copyright 2014 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 import("//build/module_args/mojo.gni")	5 import("//build/module_args/mojo.gni")

6 import("$mojo_sdk_root/mojo/public/mojo_sdk.gni")	6 import("$mojo_sdk_root/mojo/public/mojo_sdk.gni")

7	7

8 mojo_sdk_source_set("cpp") {	8 mojo_sdk_source_set("cpp") {

9 restrict_external_deps = false	9 restrict_external_deps = false

10 public_configs = [ "../../public/build/config:mojo_services" ]	10 public_configs = [ "../../public/build/config:mojo_services" ]
	viettrungluu 2015/12/17 23:05:29 See mojo/services/public/build/config/BUILD.gn. W See mojo/services/public/build/config/BUILD.gn. Without the relative include(s?), I guess you don't need this. Maybe we should get rid of mojo/services/public/build/config/BUILD.gn entirely? jeffbrown 2015/12/18 01:41:22 Yeah, the relative includes are really annoying si Show quoted text On 2015/12/17 23:05:29, viettrungluu wrote: > See mojo/services/public/build/config/BUILD.gn. > > Without the relative include(s?), I guess you don't need this. Maybe we should > get rid of mojo/services/public/build/config/BUILD.gn entirely? Yeah, the relative includes are really annoying since they affect all downstream code too. Would be nice to get rid of that.
11 sources = [	11 sources = [

	12 "geometry_util.cc",

12 "geometry_util.h",	13 "geometry_util.h",

	14 "logging.cc",

	15 "logging.h",

13 ]	16 ]

14	17

15 deps = [	18 deps = [

16 "../interfaces",	19 "../interfaces",

17 ]	20 ]

18 }	21 }

OLD	NEW