Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 1537613002: X87: [runtime] Drop FIRST/LAST_NONCALLABLE_SPEC_OBJECT instance type range. (Closed)

Created:
5 years ago by zhengxing.li
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [runtime] Drop FIRST/LAST_NONCALLABLE_SPEC_OBJECT instance type range. port aafc3e54848af981f02b076cc9cfe7e54a67ad6d (r32926) original commit message: The FIRST-LAST_NONCALLABLE_SPEC_OBJECT_TYPE range was accidentially used in field type tracking, where we should check for JSReceiver instead (there's no need to exclude JSProxy or JSFunction from tracking). And the use in %_ClassOf was actually wrong and didn't match the C++ implementation in JSReceiver::class_name() anymore. Now it's consistent again. BUG= Committed: https://crrev.com/e1b84ed223dbeeb7cd4abaf512a043366641c052 Cr-Commit-Position: refs/heads/master@{#32937}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -42 lines) Patch
M src/crankshaft/x87/lithium-codegen-x87.cc View 1 chunk +2 lines, -17 lines 0 comments Download
M src/full-codegen/x87/full-codegen-x87.cc View 2 chunks +15 lines, -25 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
5 years ago (2015-12-17 07:45:40 UTC) #2
Weiliang
lgtm
5 years ago (2015-12-17 10:14:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1537613002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1537613002/1
5 years ago (2015-12-17 10:14:49 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-17 10:33:26 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-17 10:33:58 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e1b84ed223dbeeb7cd4abaf512a043366641c052
Cr-Commit-Position: refs/heads/master@{#32937}

Powered by Google App Engine
This is Rietveld 408576698