Added window.internals.isColorChooserShown()

Added window.internals.isColorChooserShown()

This change adds internals.isColorChooserShown() and
a mock ColorChooser implementation for TestRunner.
Without the mock, color pickers aren't recognized as closed.

This is a preparation for crbug.com/234810.

BUG=234810
TEST=input-color-chooser-shown.html

[Hajime Morrita, 2013-05-21 04:57:21]

Hi, could you take a look?
This change is just adding an internals API for color picker.

[tkent, 2013-05-21 05:20:43]

https://codereview.chromium.org/15376006/diff/1/LayoutTests/fast/forms/color/...
File LayoutTests/fast/forms/color/input-color-chooser-shown.html (right):

https://codereview.chromium.org/15376006/diff/1/LayoutTests/fast/forms/color/...
LayoutTests/fast/forms/color/input-color-chooser-shown.html:14:
eventSender.mouseMoveTo(target.offsetLeft, target.offsetTop +
target.offsetHeight / 2);
You can include ../resources/common.js and use clickElement(target).

https://codereview.chromium.org/15376006/diff/1/Source/core/testing/Internals...
File Source/core/testing/Internals.idl (right):

https://codereview.chromium.org/15376006/diff/1/Source/core/testing/Internals...
Source/core/testing/Internals.idl:80: boolean isColorChooserShown(Element
element);
I don't think this should belong to Internals.  TestRunner can know existence of
a ColorChooser without Internals help, right?

https://codereview.chromium.org/15376006/diff/1/Tools/DumpRenderTree/chromium...
File Tools/DumpRenderTree/chromium/TestRunner/src/ColorChooser.h (right):

https://codereview.chromium.org/15376006/diff/1/Tools/DumpRenderTree/chromium...
Tools/DumpRenderTree/chromium/TestRunner/src/ColorChooser.h:43: class
ColorChooser : public WebKit::WebColorChooser {
I'd like to name this 'MockColorChooser.'

[keishi, 2013-05-21 05:20:54]

https://codereview.chromium.org/15376006/diff/1/Source/core/html/HTMLInputEle...
File Source/core/html/HTMLInputElement.cpp (right):

https://codereview.chromium.org/15376006/diff/1/Source/core/html/HTMLInputEle...
Source/core/html/HTMLInputElement.cpp:1493: if (!m_inputType->isColorControl())
We decided not to branch depending on type inside HTMLInputElement.cpp, for new
code.

I think we can make this not color chooser specific and use one
method(internals.isChooserShown) for all chooser dialogs.

[Hajime Morrita, 2013-05-21 06:11:23]

Thanks for the review! An update will come soon!

https://codereview.chromium.org/15376006/diff/1/LayoutTests/fast/forms/color/...
File LayoutTests/fast/forms/color/input-color-chooser-shown.html (right):

https://codereview.chromium.org/15376006/diff/1/LayoutTests/fast/forms/color/...
LayoutTests/fast/forms/color/input-color-chooser-shown.html:14:
eventSender.mouseMoveTo(target.offsetLeft, target.offsetTop +
target.offsetHeight / 2);
Cool!

https://codereview.chromium.org/15376006/diff/1/Source/core/html/HTMLInputEle...
File Source/core/html/HTMLInputElement.cpp (right):

https://codereview.chromium.org/15376006/diff/1/Source/core/html/HTMLInputEle...
Source/core/html/HTMLInputElement.cpp:1493: if (!m_inputType->isColorControl())
OK, let me do that.

https://codereview.chromium.org/15376006/diff/1/Source/core/testing/Internals...
File Source/core/testing/Internals.idl (right):

https://codereview.chromium.org/15376006/diff/1/Source/core/testing/Internals...
Source/core/testing/Internals.idl:80: boolean isColorChooserShown(Element
element);
OK, I'll move this to TestRunner.

https://codereview.chromium.org/15376006/diff/1/Tools/DumpRenderTree/chromium...
File Tools/DumpRenderTree/chromium/TestRunner/src/ColorChooser.h (right):

https://codereview.chromium.org/15376006/diff/1/Tools/DumpRenderTree/chromium...
Tools/DumpRenderTree/chromium/TestRunner/src/ColorChooser.h:43: class
ColorChooser : public WebKit::WebColorChooser {
Sure.

[Hajime Morrita, 2013-05-21 06:24:57]

Uh, my update made new issue for some reason :-(
https://codereview.chromium.org/15535005
Could you take this new one? I'll close this...