Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issue 1537563006: Remove ugly check for super.created call in constructor (Closed)

Created:
5 years ago by Alan Knight
Modified:
5 years ago
Reviewers:
terry, jakemac
CC:
reviews_dartlang.org, ricow1
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove ugly check for super.created call in constructor BUG= R=terry@google.com Committed: https://github.com/dart-lang/sdk/commit/168e9ee882b67e0a61a005ff0c7c9f4b8ca9b81e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -16 lines) Patch
M sdk/lib/html/dartium/html_dartium.dart View 1 chunk +1 line, -8 lines 0 comments Download
M tools/dom/templates/html/impl/impl_HTMLDocument.darttemplate View 1 chunk +1 line, -8 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Alan Knight
5 years ago (2015-12-18 00:40:41 UTC) #2
terry
Thanks Alan. LGTM Might want to add this bug to the CL it fixes - ...
5 years ago (2015-12-18 13:43:03 UTC) #3
Alan Knight
5 years ago (2015-12-18 17:41:54 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
168e9ee882b67e0a61a005ff0c7c9f4b8ca9b81e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698