runtime/vm/compiler.cc - Issue 1537543002: Fix for issue 25236

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/compiler.cc

Issue 1537543002: Fix for issue 25236 (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: code-review-comments Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/compiler.cc

diff --git a/runtime/vm/compiler.cc b/runtime/vm/compiler.cc

index 17edba21304752b57196c29c0145413142377cbf..a653a7db208686fc303e3de0abdcd8433a3abd6e 100644

--- a/runtime/vm/compiler.cc

+++ b/runtime/vm/compiler.cc

@@ -1754,7 +1754,8 @@ void BackgroundCompiler::Run() {

while (running_) {

// Maybe something is already in the queue, check first before waiting

// to be notified.

- Thread::EnterIsolateAsHelper(isolate_);

+ bool result = Thread::EnterIsolateAsHelper(isolate_);

+ ASSERT(result);

{

Thread* thread = Thread::Current();

StackZone stack_zone(thread);

« no previous file with comments | « no previous file | runtime/vm/dart.cc » ('j') | no next file with comments »