Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Issue 1537523002: Add dart:developer.postEvent for posting events to the service protocol from Dart code (Closed)

Created:
5 years ago by Cutch
Modified:
5 years ago
Reviewers:
turnidge
CC:
reviews_dartlang.org, turnidge, rmacnak, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add dart:developer.postEvent for posting events to the service protocol from Dart code - Add dart:developer.postEvent for posting events to the service protocol. - Add 'Extension' service protocol event stream. - Unit test. - Update service.md - Bug fix for logging stream. R=turnidge@google.com Committed: https://github.com/dart-lang/sdk/commit/89c49b9e87a08f553a5f3c92f3d50dcb6e9ad77d

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+139 lines, -2 lines) Patch
M runtime/lib/developer.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M runtime/lib/developer.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/service/object.dart View 4 chunks +9 lines, -0 lines 0 comments Download
M runtime/observatory/tests/service/developer_extension_test.dart View 2 chunks +11 lines, -0 lines 0 comments Download
M runtime/vm/bootstrap_natives.h View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/json_stream.h View 1 chunk +4 lines, -0 lines 0 comments Download
M runtime/vm/json_stream.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M runtime/vm/service.h View 2 chunks +5 lines, -0 lines 0 comments Download
M runtime/vm/service.cc View 4 chunks +20 lines, -0 lines 0 comments Download
M runtime/vm/service/service.md View 1 2 3 4 chunks +26 lines, -2 lines 0 comments Download
M runtime/vm/service_event.h View 4 chunks +12 lines, -0 lines 0 comments Download
M runtime/vm/service_event.cc View 4 chunks +14 lines, -0 lines 0 comments Download
M sdk/lib/developer/extension.dart View 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Cutch
5 years ago (2015-12-16 23:22:02 UTC) #4
turnidge
lgtm https://codereview.chromium.org/1537523002/diff/1/runtime/vm/service/service.md File runtime/vm/service/service.md (right): https://codereview.chromium.org/1537523002/diff/1/runtime/vm/service/service.md#newcode1157 runtime/vm/service/service.md:1157: object extensionData [optional]; Change this to ExtensionData or ...
5 years ago (2015-12-17 17:27:15 UTC) #5
Cutch
https://codereview.chromium.org/1537523002/diff/1/runtime/vm/service/service.md File runtime/vm/service/service.md (right): https://codereview.chromium.org/1537523002/diff/1/runtime/vm/service/service.md#newcode1157 runtime/vm/service/service.md:1157: object extensionData [optional]; On 2015/12/17 17:27:15, turnidge wrote: > ...
5 years ago (2015-12-17 17:34:39 UTC) #6
Cutch
5 years ago (2015-12-17 17:34:57 UTC) #8
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
89c49b9e87a08f553a5f3c92f3d50dcb6e9ad77d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698