Status page diagnostics for elements and docs.

Status page diagnostics for elements and docs.

Related to profiling the cost of storing element docs but the element counts themselves are generally interesting.

Background: https://github.com/dart-lang/sdk/issues/23694

R=brianwilkerson@google.com

Committed: https://github.com/dart-lang/sdk/commit/0a32c6b2907256fa6560e00b87edc45252d9a970

[pquitslund, 2015-12-16 23:14:17]

pquitslund@google.com changed reviewers:
+ brianwilkerson@google.com

[Brian Wilkerson, 2015-12-16 23:38:53]

LGTM

https://codereview.chromium.org/1537503002/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/status/get_handler.dart (right):

https://codereview.chromium.org/1537503002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/status/get_handler.dart:67: SourceRange docRange =
element.docRange;
I think you're about to remove this API. :-)

[pquitslund, 2015-12-16 23:46:42]

Thanks!

https://codereview.chromium.org/1537503002/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/status/get_handler.dart (right):

https://codereview.chromium.org/1537503002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/status/get_handler.dart:67: SourceRange docRange =
element.docRange;
On 2015/12/16 23:38:53, Brian Wilkerson wrote:
> I think you're about to remove this API. :-)

: ) Yep.  When I do, I was thinking we may still want to do something like:

    totalDocSpan += element.computeDocumentationComment()?.length() ?? 0;

in case we want to easily keep tracking doc size.

[pquitslund, 2015-12-16 23:47:55]

Description was changed from

==========
Status page diagnostics for elements and docs.

Related to profiling the cost of storing element docs but the element counts
themselves are generally interesting.

Background: https://github.com/dart-lang/sdk/issues/23694
==========

to

==========
Status page diagnostics for elements and docs.

Related to profiling the cost of storing element docs but the element counts
themselves are generally interesting.

Background: https://github.com/dart-lang/sdk/issues/23694

R=brianwilkerson@google.com

Committed:
https://github.com/dart-lang/sdk/commit/0a32c6b2907256fa6560e00b87edc45252d9a970
==========

[pquitslund, 2015-12-16 23:47:56]

Committed patchset #1 (id:1) manually as
0a32c6b2907256fa6560e00b87edc45252d9a970 (presubmit successful).