Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(709)

Unified Diff: ui/touch_selection/touch_selection_controller.cc

Issue 1537493006: Allow scrolling a page with selection after long-press on whitespace (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added a comment Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/touch_selection/touch_selection_controller.cc
diff --git a/ui/touch_selection/touch_selection_controller.cc b/ui/touch_selection/touch_selection_controller.cc
index 90f7c6241580f66532ff678d360f070a8fa82bc3..35cdf1af190be4e4d738eda373e0f7c5ae37c9b2 100644
--- a/ui/touch_selection/touch_selection_controller.cc
+++ b/ui/touch_selection/touch_selection_controller.cc
@@ -231,6 +231,15 @@ bool TouchSelectionController::WillHandleLongPressEvent(
return false;
}
+void TouchSelectionController::OnScrollBeginEvent() {
+ longpress_drag_selector_.OnScrollBeginEvent();
+ response_pending_input_event_ = INPUT_EVENT_TYPE_NONE;
+ if (active_status_ == INACTIVE) {
+ activate_insertion_automatically_ = false;
+ activate_selection_automatically_ = false;
+ }
+}
+
void TouchSelectionController::AllowShowingFromCurrentSelection() {
if (active_status_ != INACTIVE)
return;

Powered by Google App Engine
This is Rietveld 408576698