Allow scrolling a page with selection after long-press on whitespace

ui/touch_selection/longpress_drag_selector_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/touch_selection/longpress_drag_selector.h"
 
 #include "testing/gtest/include/gtest/gtest.h"
 #include "ui/events/test/motion_event_test_utils.h"
 
 using ui::test::MockMotionEvent;
@@ skipping 69 matching lines @@
   MockMotionEvent event;
 
   // Start a touch sequence.
   EXPECT_FALSE(selector.WillHandleTouchEvent(event.PressPoint(0, 0)));
   EXPECT_FALSE(GetAndResetActiveStateChanged());
 
   // Activate a longpress-triggered selection.
   gfx::PointF selection_start(0, 10);
   gfx::PointF selection_end(10, 10);
   selector.OnLongPressEvent(event.GetEventTime(), gfx::PointF());
-  EXPECT_TRUE(GetAndResetActiveStateChanged());
+  EXPECT_FALSE(GetAndResetActiveStateChanged());
 
   // Motion should not be consumed until a selection is detected.
   EXPECT_FALSE(selector.WillHandleTouchEvent(event.MovePoint(0, 0, 0)));
   SetSelection(selection_start, selection_end);
   selector.OnSelectionActivated();
+  EXPECT_TRUE(GetAndResetActiveStateChanged());
   EXPECT_FALSE(IsDragging());
 
   // Initiate drag motion.  Note that the first move event after activation is
   // used to initialize the drag start anchor.
   EXPECT_TRUE(selector.WillHandleTouchEvent(event.MovePoint(0, 0, 0)));
   EXPECT_FALSE(IsDragging());
 
   // The first slop exceeding motion will start the drag. As the motion is
   // downward, the end selection point should be moved.
   EXPECT_TRUE(selector.WillHandleTouchEvent(event.MovePoint(0, 0, kSlop)));
@@ skipping 20 matching lines @@
   MockMotionEvent event;
 
   // Start a touch sequence.
   EXPECT_FALSE(selector.WillHandleTouchEvent(event.PressPoint(0, 0)));
   EXPECT_FALSE(GetAndResetActiveStateChanged());
 
   // Activate a longpress-triggered selection.
   gfx::PointF selection_start(0, 10);
   gfx::PointF selection_end(10, 10);
   selector.OnLongPressEvent(event.GetEventTime(), gfx::PointF());
-  EXPECT_TRUE(GetAndResetActiveStateChanged());
+  EXPECT_FALSE(GetAndResetActiveStateChanged());
   SetSelection(selection_start, selection_end);
   selector.OnSelectionActivated();
+  EXPECT_TRUE(GetAndResetActiveStateChanged());
   EXPECT_FALSE(IsDragging());
 
   // Initiate drag motion.
   EXPECT_TRUE(selector.WillHandleTouchEvent(event.MovePoint(0, 5, 0)));
   EXPECT_FALSE(IsDragging());
 
   // As the initial motion is leftward, toward the selection start, the
   // selection start should be the drag point.
   EXPECT_TRUE(selector.WillHandleTouchEvent(event.MovePoint(0, -kSlop, 0)));
   EXPECT_TRUE(IsDragging());
@@ skipping 92 matching lines @@
 }
 
 TEST_F(LongPressDragSelectorTest, NoSelection) {
   LongPressDragSelector selector(this);
   MockMotionEvent event;
 
   // Start a touch sequence.
   EXPECT_FALSE(selector.WillHandleTouchEvent(event.PressPoint(0, 0)));
   EXPECT_FALSE(GetAndResetActiveStateChanged());
 
-  // Trigger a longpress. This will notify the client that detection is active,
-  // but until there's a longpress no drag selection should occur.
+  // Trigger a longpress.
   selector.OnLongPressEvent(event.GetEventTime(), gfx::PointF());
-  EXPECT_TRUE(GetAndResetActiveStateChanged());
+  EXPECT_FALSE(GetAndResetActiveStateChanged());
   EXPECT_FALSE(IsDragging());
 
   // Touch movement should not initiate selection drag, as there is no active
   // selection.
   EXPECT_FALSE(selector.WillHandleTouchEvent(event.MovePoint(0, 0, 0)));
   EXPECT_FALSE(selector.WillHandleTouchEvent(event.MovePoint(0, 0, kSlop)));
   EXPECT_FALSE(selector.WillHandleTouchEvent(event.MovePoint(0, 0, kSlop * 2)));
   EXPECT_FALSE(IsDragging());
   EXPECT_EQ(gfx::PointF(), DragPosition());
 
   EXPECT_FALSE(selector.WillHandleTouchEvent(event.ReleasePoint()));
-  EXPECT_TRUE(GetAndResetActiveStateChanged());
 }
 
 TEST_F(LongPressDragSelectorTest, NoDragMotion) {
   LongPressDragSelector selector(this);
   MockMotionEvent event;
 
   // Start a touch sequence.
   EXPECT_FALSE(selector.WillHandleTouchEvent(event.PressPoint(0, 0)));
   EXPECT_FALSE(GetAndResetActiveStateChanged());
 
   // Activate a longpress-triggered selection.
   selector.OnLongPressEvent(event.GetEventTime(), gfx::PointF());
-  EXPECT_TRUE(GetAndResetActiveStateChanged());
+  EXPECT_FALSE(GetAndResetActiveStateChanged());
   gfx::PointF selection_start(0, 10);
   gfx::PointF selection_end(10, 10);
   SetSelection(selection_start, selection_end);
   selector.OnSelectionActivated();
+  EXPECT_TRUE(GetAndResetActiveStateChanged());
   EXPECT_FALSE(IsDragging());
 
   // Touch movement within the slop region should not initiate selection drag.
   EXPECT_TRUE(selector.WillHandleTouchEvent(event.MovePoint(0, 0, 0)));
   EXPECT_TRUE(selector.WillHandleTouchEvent(event.MovePoint(0, 0, kSlop / 2)));
   EXPECT_TRUE(selector.WillHandleTouchEvent(event.MovePoint(0, 0, -kSlop / 2)));
   EXPECT_FALSE(IsDragging());
   EXPECT_EQ(gfx::PointF(), DragPosition());
 
   EXPECT_FALSE(selector.WillHandleTouchEvent(event.ReleasePoint()));
   EXPECT_TRUE(GetAndResetActiveStateChanged());
 }
 
 TEST_F(LongPressDragSelectorTest, SelectionDeactivated) {
   LongPressDragSelector selector(this);
   MockMotionEvent event;
 
   // Start a touch sequence.
   EXPECT_FALSE(selector.WillHandleTouchEvent(event.PressPoint(0, 0)));
   EXPECT_FALSE(GetAndResetActiveStateChanged());
 
   // Activate a longpress-triggered selection.
   selector.OnLongPressEvent(event.GetEventTime(), gfx::PointF());
-  EXPECT_TRUE(GetAndResetActiveStateChanged());
+  EXPECT_FALSE(GetAndResetActiveStateChanged());
   gfx::PointF selection_start(0, 10);
   gfx::PointF selection_end(10, 10);
   SetSelection(selection_start, selection_end);
   selector.OnSelectionActivated();
+  EXPECT_TRUE(GetAndResetActiveStateChanged());
   EXPECT_FALSE(IsDragging());
 
   // Start a drag selection.
   EXPECT_TRUE(selector.WillHandleTouchEvent(event.MovePoint(0, 0, 0)));
   EXPECT_TRUE(selector.WillHandleTouchEvent(event.MovePoint(0, 0, kSlop)));
   EXPECT_TRUE(selector.WillHandleTouchEvent(event.MovePoint(0, 0, kSlop * 2)));
   EXPECT_TRUE(IsDragging());
 
   // Clearing the selection should force an end to the drag.
   selector.OnSelectionDeactivated();
@@ skipping 13 matching lines @@
   MockMotionEvent event;
 
   // Start a touch sequence.
   EXPECT_FALSE(selector.WillHandleTouchEvent(event.PressPoint(0, 0)));
   EXPECT_FALSE(GetAndResetActiveStateChanged());
 
   // Activate a longpress-triggered selection.
   gfx::PointF selection_start(0, 10);
   gfx::PointF selection_end(10, 10);
   selector.OnLongPressEvent(event.GetEventTime(), gfx::PointF());
-  EXPECT_TRUE(GetAndResetActiveStateChanged());
+  EXPECT_FALSE(GetAndResetActiveStateChanged());
   SetSelection(selection_start, selection_end);
   selector.OnSelectionActivated();
+  EXPECT_TRUE(GetAndResetActiveStateChanged());
   EXPECT_FALSE(IsDragging());
 
   // Initiate drag motion.
   EXPECT_TRUE(selector.WillHandleTouchEvent(event.MovePoint(0, 15, 5)));
   EXPECT_FALSE(IsDragging());
 
   // As the initial motion exceeds both endpoints, the closer bound should
   // be used for dragging, in this case the selection end.
   EXPECT_TRUE(selector.WillHandleTouchEvent(
       event.MovePoint(0, 15.f + kSlop * 2.f, 5.f + kSlop)));
   EXPECT_TRUE(IsDragging());
   EXPECT_EQ(selection_end, DragPosition());
 
   // Release the touch sequence, ending the drag.
   EXPECT_FALSE(selector.WillHandleTouchEvent(event.ReleasePoint()));
   EXPECT_FALSE(IsDragging());
   EXPECT_TRUE(GetAndResetActiveStateChanged());
 }
 
+TEST_F(LongPressDragSelectorTest, ScrollAfterLongPress) {
+  LongPressDragSelector selector(this);
+  MockMotionEvent event;
+  gfx::PointF touch_point(0, 0);
+
+  // Start a touch sequence.
+  EXPECT_FALSE(selector.WillHandleTouchEvent(
+      event.PressPoint(touch_point.x(), touch_point.y())));
+
+  // Long-press and hold down.
+  selector.OnLongPressEvent(event.GetEventTime(), touch_point);
+
+  // Scroll the page. This should cancel long-press drag gesture.
+  touch_point.Offset(0, 2 * kSlop);
+  EXPECT_FALSE(selector.WillHandleTouchEvent(
+      event.MovePoint(0, touch_point.x(), touch_point.y())));
+  selector.OnScrollBeginEvent();
+
+  // Now if the selection is activated, because long-press drag gesture was
+  // canceled, active state of the long-press selector should not change.
+  selector.OnSelectionActivated();
+  EXPECT_FALSE(GetAndResetActiveStateChanged());
+
+  // Release the touch sequence.
+  selector.WillHandleTouchEvent(event.ReleasePoint());
+}
+
 }  // namespace ui