clang/win: Fix build after https://codereview.chromium.org/1525263004/

clang/win: Fix build after https://codereview.chromium.org/1525263004/

Fixes

..\..\testing/gtest/include/gtest/gtest.h(1392,16) :  error: comparison of
    integers of different signs: 'const int' and 'const unsigned long'
    [-Werror,-Wsign-compare]
  if (expected == actual) {
      ~~~~~~~~ ^  ~~~~~~
..\..\content\common\cursors\webcursor_unittest.cc(301,3) :  note: in
      instantiation of function template specialization
      'testing::internal::EqHelper<false>::Compare<int, unsigned long>' here
  EXPECT_EQ(static_cast<int>(scaleFactor * hotspotX), windowsIconInfo.xHotspot);

BUG=82385, 567877, 161614
TBR=bsep@chromium.org

[Nico, 2015-12-17 12:09:21]

Description was changed from

==========
clang/win: Fix build after https://codereview.chromium.org/1525263004/

Fixes

..\..\testing/gtest/include/gtest/gtest.h(1392,16) :  error: comparison of
    integers of different signs: 'const int' and 'const unsigned long'
    [-Werror,-Wsign-compare]
  if (expected == actual) {
      ~~~~~~~~ ^  ~~~~~~
..\..\content\common\cursors\webcursor_unittest.cc(301,3) :  note: in
      instantiation of function template specialization
      'testing::internal::EqHelper<false>::Compare<int, unsigned long>' here
  EXPECT_EQ(static_cast<int>(scaleFactor * hotspotX), windowsIconInfo.xHotspot);

BUG=82385,567877
==========

to

==========
clang/win: Fix build after https://codereview.chromium.org/1525263004/

Fixes

..\..\testing/gtest/include/gtest/gtest.h(1392,16) :  error: comparison of
    integers of different signs: 'const int' and 'const unsigned long'
    [-Werror,-Wsign-compare]
  if (expected == actual) {
      ~~~~~~~~ ^  ~~~~~~
..\..\content\common\cursors\webcursor_unittest.cc(301,3) :  note: in
      instantiation of function template specialization
      'testing::internal::EqHelper<false>::Compare<int, unsigned long>' here
  EXPECT_EQ(static_cast<int>(scaleFactor * hotspotX), windowsIconInfo.xHotspot);

BUG=82385,567877,161614
TBR=bsep@chromium.org
==========

[Nico, 2015-12-17 12:09:27]

thakis@chromium.org changed reviewers:
+ bsep@chromium.org

[Nico, 2015-12-17 12:09:30]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2015-12-17 12:09:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1537483003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1537483003/1

[commit-bot: I haz the power, 2015-12-17 12:39:06]

Description was changed from

==========
clang/win: Fix build after https://codereview.chromium.org/1525263004/

Fixes

..\..\testing/gtest/include/gtest/gtest.h(1392,16) :  error: comparison of
    integers of different signs: 'const int' and 'const unsigned long'
    [-Werror,-Wsign-compare]
  if (expected == actual) {
      ~~~~~~~~ ^  ~~~~~~
..\..\content\common\cursors\webcursor_unittest.cc(301,3) :  note: in
      instantiation of function template specialization
      'testing::internal::EqHelper<false>::Compare<int, unsigned long>' here
  EXPECT_EQ(static_cast<int>(scaleFactor * hotspotX), windowsIconInfo.xHotspot);

BUG=82385,567877,161614
TBR=bsep@chromium.org
==========

to

==========
clang/win: Fix build after https://codereview.chromium.org/1525263004/

Fixes

..\..\testing/gtest/include/gtest/gtest.h(1392,16) :  error: comparison of
    integers of different signs: 'const int' and 'const unsigned long'
    [-Werror,-Wsign-compare]
  if (expected == actual) {
      ~~~~~~~~ ^  ~~~~~~
..\..\content\common\cursors\webcursor_unittest.cc(301,3) :  note: in
      instantiation of function template specialization
      'testing::internal::EqHelper<false>::Compare<int, unsigned long>' here
  EXPECT_EQ(static_cast<int>(scaleFactor * hotspotX), windowsIconInfo.xHotspot);

BUG=82385,567877,161614
TBR=bsep@chromium.org

Committed: https://crrev.com/83201c236e56ee4725a2543db01b5bef5f1674fc
Cr-Commit-Position: refs/heads/master@{#365812}
==========

[commit-bot: I haz the power, 2015-12-17 12:39:07]

Patchset 1 (id:??) landed as
https://crrev.com/83201c236e56ee4725a2543db01b5bef5f1674fc
Cr-Commit-Position: refs/heads/master@{#365812}

[Nico, 2015-12-17 12:39:33]

Description was changed from

==========
clang/win: Fix build after https://codereview.chromium.org/1525263004/

Fixes

..\..\testing/gtest/include/gtest/gtest.h(1392,16) :  error: comparison of
    integers of different signs: 'const int' and 'const unsigned long'
    [-Werror,-Wsign-compare]
  if (expected == actual) {
      ~~~~~~~~ ^  ~~~~~~
..\..\content\common\cursors\webcursor_unittest.cc(301,3) :  note: in
      instantiation of function template specialization
      'testing::internal::EqHelper<false>::Compare<int, unsigned long>' here
  EXPECT_EQ(static_cast<int>(scaleFactor * hotspotX), windowsIconInfo.xHotspot);

BUG=82385,567877,161614
TBR=bsep@chromium.org

Committed: https://crrev.com/83201c236e56ee4725a2543db01b5bef5f1674fc
Cr-Commit-Position: refs/heads/master@{#365812}
==========

to

==========
clang/win: Fix build after https://codereview.chromium.org/1525263004/

Fixes

..\..\testing/gtest/include/gtest/gtest.h(1392,16) :  error: comparison of
    integers of different signs: 'const int' and 'const unsigned long'
    [-Werror,-Wsign-compare]
  if (expected == actual) {
      ~~~~~~~~ ^  ~~~~~~
..\..\content\common\cursors\webcursor_unittest.cc(301,3) :  note: in
      instantiation of function template specialization
      'testing::internal::EqHelper<false>::Compare<int, unsigned long>' here
  EXPECT_EQ(static_cast<int>(scaleFactor * hotspotX), windowsIconInfo.xHotspot);

BUG=82385,567877,161614
TBR=bsep@chromium.org
==========

[Nico, 2015-12-17 12:39:34]

Committed patchset #1 (id:1) to pending queue manually as
ec2b43a626818811c38cd71f5bc01d78a5a0bf64 (presubmit successful).

[Bret, 2015-12-17 19:25:51]

On 2015/12/17 12:39:34, Nico (office move Wed Thu Fri) wrote:
> Committed patchset #1 (id:1) to pending queue manually as
> ec2b43a626818811c38cd71f5bc01d78a5a0bf64 (presubmit successful).

lgtm thanks for fixing this