Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 1537483002: Fixup GL instanced rendering commands (Closed)

Created:
5 years ago by Chris Dalton
Modified:
5 years ago
Reviewers:
jvanverth1, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fixup GL instanced rendering commands We've ended up with a flag in both GrCaps and GrGLCaps to indicate the same instanced rendering functionality. This change removes the GrGLCaps version of the flag and also also fixes the interface assembler to use the proper suffix when loading the EXT version of the extension. BUG=skia: Committed: https://skia.googlesource.com/skia/+/1250944aaa9251c08eda3a37b21f15106903f42d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -18 lines) Patch
M src/gpu/gl/GrGLAssembleInterface.cpp View 1 chunk +7 lines, -2 lines 0 comments Download
M src/gpu/gl/GrGLCaps.h View 2 chunks +0 lines, -4 lines 0 comments Download
M src/gpu/gl/GrGLCaps.cpp View 3 chunks +0 lines, -12 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Chris Dalton
5 years ago (2015-12-16 22:34:11 UTC) #2
bsalomon
lgtm
5 years ago (2015-12-17 16:03:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1537483002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1537483002/1
5 years ago (2015-12-17 18:55:07 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-17 19:11:43 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/1250944aaa9251c08eda3a37b21f15106903f42d

Powered by Google App Engine
This is Rietveld 408576698