chrome/common/extensions/api/extension_action/browser_action_manifest_unittest.cc - Issue 1537473003: Change extension icon load errors to warnings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/api/extension_action/browser_action_manifest_unittest.cc

Issue 1537473003: Change extension icon load errors to warnings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: conciser Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/extension_action/browser_action_apitest.cc ('K') | « chrome/common/extensions/api/extension_action/action_info.cc ('k') | chrome/common/extensions/manifest_tests/extension_manifests_icons_unittest.cc » ('j') | chrome/test/data/extensions/api_test/browser_action/multi_icons/manifest.json » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/api/extension_action/browser_action_manifest_unittest.cc

diff --git a/chrome/common/extensions/api/extension_action/browser_action_manifest_unittest.cc b/chrome/common/extensions/api/extension_action/browser_action_manifest_unittest.cc

index 539477b64c8b4447ac754c116001bc857780ae53..30b4e75e6a02fe5b896b58358f31dd1225d28d10 100644

--- a/chrome/common/extensions/api/extension_action/browser_action_manifest_unittest.cc

+++ b/chrome/common/extensions/api/extension_action/browser_action_manifest_unittest.cc

@@ -81,6 +81,8 @@ TEST_F(BrowserActionManifestTest,

.Set("19", "icon19.png")

.Set("24", "icon24.png")

.Set("38", "icon38.png"))))

+ // Don't check for existence of icons.

Devlin 2015/12/17 22:05:58 This is very unintuitive, since other code states

Evan Stade 2015/12/17 22:56:06 During the validation phase, not during the parsin

+ .SetLocation(Manifest::UNPACKED)

.Build();

ASSERT_TRUE(extension.get());