chrome/common/extensions/manifest_tests/extension_manifests_icons_unittest.cc - Issue 1537473003: Change extension icon load errors to warnings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/manifest_tests/extension_manifests_icons_unittest.cc

Issue 1537473003: Change extension icon load errors to warnings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/api/extension_action/browser_action_manifest_unittest.cc ('k') | chrome/test/data/extensions/api_test/browser_action/multi_icons/background.html » ('j') | extensions/common/manifest_handler_helpers.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/manifest_tests/extension_manifests_icons_unittest.cc

diff --git a/chrome/common/extensions/manifest_tests/extension_manifests_icons_unittest.cc b/chrome/common/extensions/manifest_tests/extension_manifests_icons_unittest.cc

index e73ba823478fb0c6401177737b569f1e4a470696..061b11df35fdad770588c4949dc5bc38a453e071 100644

--- a/chrome/common/extensions/manifest_tests/extension_manifests_icons_unittest.cc

+++ b/chrome/common/extensions/manifest_tests/extension_manifests_icons_unittest.cc

@@ -17,7 +17,7 @@ class IconsManifestTest : public ChromeManifestTest {

TEST_F(IconsManifestTest, NormalizeIconPaths) {

scoped_refptr<extensions::Extension> extension(

- LoadAndExpectSuccess("normalize_icon_paths.json"));

+ LoadAndExpectSuccess("normalize_icon_paths.json", Manifest::UNPACKED));

const ExtensionIconSet& icons = IconsInfo::GetIcons(extension.get());

EXPECT_EQ("16.png", icons.Get(extension_misc::EXTENSION_ICON_BITTY,

@@ -28,7 +28,7 @@ TEST_F(IconsManifestTest, NormalizeIconPaths) {

TEST_F(IconsManifestTest, IconSizes) {

scoped_refptr<extensions::Extension> extension(

- LoadAndExpectSuccess("init_icon_size.json"));

+ LoadAndExpectSuccess("init_icon_size.json", Manifest::UNPACKED));

const ExtensionIconSet& icons = IconsInfo::GetIcons(extension.get());

EXPECT_EQ("16.png", icons.Get(extension_misc::EXTENSION_ICON_BITTY,