chrome/common/extensions/api/extension_action/action_info.h - Issue 1537473003: Change extension icon load errors to warnings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/api/extension_action/action_info.h

Issue 1537473003: Change extension icon load errors to warnings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: ultimate weirdness Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/common/extensions/api/extension_action/action_info.h

diff --git a/chrome/common/extensions/api/extension_action/action_info.h b/chrome/common/extensions/api/extension_action/action_info.h

index 09e497c6b93d8bd2a75bebba562a1a1714d2fa3b..3ad0a25ae50a7280d7faed40db21d5828f180734 100644

--- a/chrome/common/extensions/api/extension_action/action_info.h

+++ b/chrome/common/extensions/api/extension_action/action_info.h

@@ -32,7 +32,7 @@ struct ActionInfo {

};

// Loads an ActionInfo from the given DictionaryValue.

- static scoped_ptr<ActionInfo> Load(const Extension* extension,

+ static scoped_ptr<ActionInfo> Load(Extension* extension,

const base::DictionaryValue* dict,

base::string16* error);