chrome/test/data/extensions/api_test/browser_action/multi_icons/manifest.json - Issue 1537473003: Change extension icon load errors to warnings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/extensions/api_test/browser_action/multi_icons/manifest.json

Issue 1537473003: Change extension icon load errors to warnings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix one more test add one more test Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/test/data/extensions/api_test/browser_action/multi_icons/background.js ('K') | « chrome/test/data/extensions/api_test/browser_action/multi_icons/icon38.png ('k') | extensions/common/file_util.h » ('j') | extensions/common/manifest_handler_helpers.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/extensions/api_test/browser_action/multi_icons/manifest.json

diff --git a/chrome/test/data/extensions/api_test/browser_action/multi_icons/manifest.json b/chrome/test/data/extensions/api_test/browser_action/multi_icons/manifest.json

new file mode 100644

index 0000000000000000000000000000000000000000..7f6df457329fe63b1219f6c482890c31a1695e15

--- /dev/null

+++ b/chrome/test/data/extensions/api_test/browser_action/multi_icons/manifest.json

@@ -0,0 +1,12 @@

+ "name": "A test extension that tests multiple browser action icons",

+ "version": "1.0",

+ "manifest_version": 2,

+ "browser_action": {

+ "default_icon": {

+ "19": "icon19.png",

Devlin 2015/12/18 22:29:02 For funzies, can we throw in a totally oddball ico

Evan Stade 2015/12/19 00:02:41 that's what the 24 is supposed to be. Or did you m

+ "24": "icon24.png",

+ "38": "icon38.png"

+ }