Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(655)

Issue 1537463003: Merge to XFA: FX_NAMESPACE_DECLARE pointless. (Closed)

Created:
5 years ago by Tom Sepez
Modified:
5 years ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Merge to XFA: FX_NAMESPACE_DECLARE pointless. Orignal Review URL: https://codereview.chromium.org/1534003002 . (cherry picked from commit fed9dd90c086c854ef13440e6022602eb9f91cfc) TBR=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/bd6344d1138cf1f0e908ce4f8408c92a48c3b38a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -6 lines) Patch
M core/include/fxcrt/fx_basic.h View 1 chunk +0 lines, -1 line 0 comments Download
M core/src/fxge/agg/include/fx_agg_driver.h View 2 chunks +4 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Tom Sepez
TBR, one trivial conflict in fx_basic.h
5 years ago (2015-12-17 21:51:36 UTC) #2
Tom Sepez
Committed patchset #1 (id:1) manually as bd6344d1138cf1f0e908ce4f8408c92a48c3b38a (presubmit successful).
5 years ago (2015-12-17 21:54:14 UTC) #4
Lei Zhang
5 years ago (2015-12-17 21:54:29 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698