build/android/generate_emma_html.py - Issue 153743008: Revert of Enable presubmit pylint in build/android.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/generate_emma_html.py

Issue 153743008: Revert of Enable presubmit pylint in build/android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Merging with changes to pylib/linker/test_case.py. Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/android/generate_emma_html.py

diff --git a/build/android/generate_emma_html.py b/build/android/generate_emma_html.py

index 93b0b0e59c5b10eafa3b3c0a97e3d9ebd081f434..463a83687c269fd46fdc2e8a9fa31e5f2c2bdcba 100755

--- a/build/android/generate_emma_html.py

+++ b/build/android/generate_emma_html.py

@@ -11,6 +11,7 @@ import json

import optparse

import os

import sys

+import traceback

from pylib import cmd_helper

from pylib import constants

@@ -35,7 +36,7 @@ def _GetFilesWithExt(root_dir, ext):

return files

-def main():

+def main(argv):

option_parser = optparse.OptionParser()

option_parser.add_option('--output', help='HTML output filename.')

option_parser.add_option('--coverage-dir', default=None,

@@ -47,7 +48,7 @@ def main():

option_parser.add_option('--cleanup', action='store_true',

help=('If set, removes coverage files generated at '

'runtime.'))

- options, _ = option_parser.parse_args()

+ options, args = option_parser.parse_args()

if not (options.coverage_dir and options.metadata_dir and options.output):

option_parser.error('One or more mandatory options are missing.')

@@ -87,4 +88,4 @@ def main():

if __name__ == '__main__':

- sys.exit(main())

+ sys.exit(main(sys.argv))

« no previous file with comments | « build/android/findbugs_diff.py ('k') | build/android/gyp/ant.py » ('j') | no next file with comments »