Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Side by Side Diff: build/android/gyp/javac.py

Issue 153743008: Revert of Enable presubmit pylint in build/android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Merging with changes to pylib/linker/test_case.py. Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « build/android/gyp/jar_toc.py ('k') | build/android/gyp/lint.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 # 2 #
3 # Copyright 2013 The Chromium Authors. All rights reserved. 3 # Copyright 2013 The Chromium Authors. All rights reserved.
4 # Use of this source code is governed by a BSD-style license that can be 4 # Use of this source code is governed by a BSD-style license that can be
5 # found in the LICENSE file. 5 # found in the LICENSE file.
6 6
7 import fnmatch 7 import fnmatch
8 import optparse 8 import optparse
9 import os 9 import os
10 import sys 10 import sys
11 11
12 # pylint: disable=F0401
13 from util import build_utils 12 from util import build_utils
14 from util import md5_check 13 from util import md5_check
15 # pylint: enable=F0401
16 14
17 15
18 def DoJavac(options): 16 def DoJavac(options):
19 output_dir = options.output_dir 17 output_dir = options.output_dir
20 18
21 src_dirs = build_utils.ParseGypList(options.src_dirs) 19 src_dirs = build_utils.ParseGypList(options.src_dirs)
22 java_files = build_utils.FindInDirectories(src_dirs, '*.java') 20 java_files = build_utils.FindInDirectories(src_dirs, '*.java')
23 if options.javac_includes: 21 if options.javac_includes:
24 javac_includes = build_utils.ParseGypList(options.javac_includes) 22 javac_includes = build_utils.ParseGypList(options.javac_includes)
25 filtered_java_files = [] 23 filtered_java_files = []
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
64 build_utils.CheckOutput(javac_cmd, print_stdout=options.chromium_code) 62 build_utils.CheckOutput(javac_cmd, print_stdout=options.chromium_code)
65 63
66 record_path = '%s/javac.md5.stamp' % options.output_dir 64 record_path = '%s/javac.md5.stamp' % options.output_dir
67 md5_check.CallAndRecordIfStale( 65 md5_check.CallAndRecordIfStale(
68 Compile, 66 Compile,
69 record_path=record_path, 67 record_path=record_path,
70 input_paths=java_files + jar_inputs, 68 input_paths=java_files + jar_inputs,
71 input_strings=javac_cmd) 69 input_strings=javac_cmd)
72 70
73 71
74 def main(): 72 def main(argv):
75 parser = optparse.OptionParser() 73 parser = optparse.OptionParser()
76 parser.add_option('--src-dirs', help='Directories containing java files.') 74 parser.add_option('--src-dirs', help='Directories containing java files.')
77 parser.add_option('--javac-includes', 75 parser.add_option('--javac-includes',
78 help='A list of file patterns. If provided, only java files that match' + 76 help='A list of file patterns. If provided, only java files that match' +
79 'one of the patterns will be compiled.') 77 'one of the patterns will be compiled.')
80 parser.add_option('--classpath', help='Classpath for javac.') 78 parser.add_option('--classpath', help='Classpath for javac.')
81 parser.add_option('--output-dir', help='Directory for javac output.') 79 parser.add_option('--output-dir', help='Directory for javac output.')
82 parser.add_option('--stamp', help='Path to touch on success.') 80 parser.add_option('--stamp', help='Path to touch on success.')
83 parser.add_option('--chromium-code', type='int', help='Whether code being ' 81 parser.add_option('--chromium-code', type='int', help='Whether code being '
84 'compiled should be built with stricter warnings for ' 82 'compiled should be built with stricter warnings for '
85 'chromium code.') 83 'chromium code.')
86 84
87 # TODO(newt): remove this once http://crbug.com/177552 is fixed in ninja. 85 # TODO(newt): remove this once http://crbug.com/177552 is fixed in ninja.
88 parser.add_option('--ignore', help='Ignored.') 86 parser.add_option('--ignore', help='Ignored.')
89 87
90 options, _ = parser.parse_args() 88 options, _ = parser.parse_args()
91 89
92 DoJavac(options) 90 DoJavac(options)
93 91
94 if options.stamp: 92 if options.stamp:
95 build_utils.Touch(options.stamp) 93 build_utils.Touch(options.stamp)
96 94
97 95
98 if __name__ == '__main__': 96 if __name__ == '__main__':
99 sys.exit(main()) 97 sys.exit(main(sys.argv))
100 98
101 99
OLDNEW
« no previous file with comments | « build/android/gyp/jar_toc.py ('k') | build/android/gyp/lint.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698