Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 153743006: Merge Parser::ReportUnexpectedToken and PreParser::ReportUnexpectedToken. (Closed)

Created:
6 years, 10 months ago by marja
Modified:
6 years, 10 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Merge Parser::ReportUnexpectedToken and PreParser::ReportUnexpectedToken. (I.e., move ReportUnexpectedToken to ParserBase.) Because of the recent unifications, they now do the same thing. BUG= R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19161

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -88 lines) Patch
M src/parser.h View 2 chunks +4 lines, -1 line 0 comments Download
M src/parser.cc View 2 chunks +36 lines, -35 lines 0 comments Download
M src/preparser.h View 1 2 4 chunks +17 lines, -6 lines 0 comments Download
M src/preparser.cc View 12 chunks +12 lines, -46 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Michael Starzinger
LGTM.
6 years, 10 months ago (2014-02-06 15:06:57 UTC) #1
marja
6 years, 10 months ago (2014-02-06 15:10:29 UTC) #2
Message was sent while issue was closed.
Committed patchset #3 manually as r19161 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698