Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(825)

Issue 1537393003: [wasm] Fixed float-to-int32 conversion to match the spec. (Closed)

Created:
5 years ago by ahaas
Modified:
5 years ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Fixed float-to-int32 conversion to match the spec. The new implementation detects if the input value is outside i32 range and traps it that case. The range check is done as follows: The input value is converted to int32 and then back to float. If the result is the same as the truncated input value, then the input value is within int32 range. R=bmeurer@chromium.org Committed: https://crrev.com/dcac1f144e4c8d37338ce9ee94cc1704e81fb0b7 Cr-Commit-Position: refs/heads/master@{#32984}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+135 lines, -13 lines) Patch
M src/compiler/wasm-compiler.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/compiler/wasm-compiler.cc View 3 chunks +73 lines, -13 lines 0 comments Download
M test/cctest/wasm/test-run-wasm.cc View 1 chunk +58 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
ahaas
5 years ago (2015-12-21 10:13:39 UTC) #1
Benedikt Meurer
I'm a bit scared that I'm wasm OWNER now :-) But this one LGTM
5 years ago (2015-12-21 10:19:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1537393003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1537393003/1
5 years ago (2015-12-21 10:21:11 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-21 10:52:57 UTC) #5
commit-bot: I haz the power
5 years ago (2015-12-21 10:53:22 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dcac1f144e4c8d37338ce9ee94cc1704e81fb0b7
Cr-Commit-Position: refs/heads/master@{#32984}

Powered by Google App Engine
This is Rietveld 408576698