Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 15373004: Auto-generate V8StyleSheetList::namedPropertyGetter (Closed)

Created:
7 years, 7 months ago by kojih
Modified:
7 years, 7 months ago
Reviewers:
haraken
CC:
blink-reviews, jsbell+bindings_chromium.org, eae+blinkwatch, abarth-chromium, dglazkov+blink, apavlov+blink_chromium.org, adamk+blink_chromium.org, darktears, haraken, Nate Chapin
Base URL:
https://chromium.googlesource.com/chromium/blink@master
Visibility:
Public.

Description

Auto-generate V8StyleSheetList::namedPropertyGetter Removed V8StyleSheetListCustom.cpp. R=haraken@chromium.org BUG=229740 TEST=No tests

Patch Set 1 #

Patch Set 2 : nit #

Patch Set 3 : rebased #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -58 lines) Patch
M Source/bindings/bindings.gypi View 1 chunk +0 lines, -1 line 0 comments Download
D Source/bindings/v8/custom/V8StyleSheetListCustom.cpp View 1 chunk +0 lines, -55 lines 1 comment Download
M Source/core/css/StyleSheetList.h View 1 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/css/StyleSheetList.cpp View 1 chunk +9 lines, -0 lines 0 comments Download
M Source/core/css/StyleSheetList.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
kojih
r? Diff of generated code: +v8::Handle<v8::Value> V8StyleSheetList::namedPropertyGetter(v8::Local<v8::String> name, const v8::AccessorInfo& info) +{ + if (!info.Holder()->GetRealNamedPropertyInPrototypeChain(name).IsEmpty()) ...
7 years, 7 months ago (2013-05-20 09:54:17 UTC) #1
kojih
Fix: attributes["item"] should be function but actually [object Attr] and attributes["item"] was "canoveride"
7 years, 7 months ago (2013-05-20 09:59:41 UTC) #2
haraken
LGTM https://codereview.chromium.org/15373004/diff/6001/Source/bindings/v8/custom/V8StyleSheetListCustom.cpp File Source/bindings/v8/custom/V8StyleSheetListCustom.cpp (left): https://codereview.chromium.org/15373004/diff/6001/Source/bindings/v8/custom/V8StyleSheetListCustom.cpp#oldcode43 Source/bindings/v8/custom/V8StyleSheetListCustom.cpp:43: if (info.Holder()->HasRealNamedProperty(name)) The fact that the previous implementation ...
7 years, 7 months ago (2013-05-20 10:25:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kojih@chromium.org/15373004/6001
7 years, 7 months ago (2013-05-20 10:32:43 UTC) #4
commit-bot: I haz the power
7 years, 7 months ago (2013-05-20 13:37:29 UTC) #5
Message was sent while issue was closed.
Change committed as 150663

Powered by Google App Engine
This is Rietveld 408576698