Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1080)

Issue 1537233002: Don't cast to ClassElementImpl where we don't need to. (Closed)

Created:
5 years ago by scheglov
Modified:
5 years ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Don't cast to ClassElementImpl where we don't need to. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/a20bbc5f7fd5caaf7b69fea954381c032e9cc1ac

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M pkg/analyzer/lib/src/dart/element/type.dart View 1 chunk +6 lines, -6 lines 0 comments Download
M pkg/analyzer/lib/src/generated/element_resolver.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
5 years ago (2015-12-20 00:06:39 UTC) #1
Brian Wilkerson
LGTM
5 years ago (2015-12-20 19:42:50 UTC) #2
scheglov
5 years ago (2015-12-20 19:59:11 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a20bbc5f7fd5caaf7b69fea954381c032e9cc1ac (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698