Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Issue 1537223002: Clear 'referenceMap' before summarizing a new unit. (Closed)

Created:
5 years ago by scheglov
Modified:
5 years ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Clear 'referenceMap' before summarizing a new unit. R=paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/8d1067566a02bfa70bbed30295f3703778ad4e2c

Patch Set 1 #

Patch Set 2 : Add a new test_all file. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -14 lines) Patch
M pkg/analyzer/lib/src/summary/summarize_elements.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer/test/src/summary/summary_test.dart View 1 chunk +7 lines, -8 lines 0 comments Download
A + pkg/analyzer/test/src/summary/test_all.dart View 1 1 chunk +6 lines, -6 lines 0 comments Download
M pkg/analyzer/test/src/test_all.dart View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
5 years ago (2015-12-19 23:38:15 UTC) #1
Paul Berry
lgtm
5 years ago (2015-12-20 15:25:36 UTC) #2
scheglov
5 years ago (2015-12-20 18:03:00 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
8d1067566a02bfa70bbed30295f3703778ad4e2c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698