Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(672)

Issue 1537203002: switch to using SaveLayerFlags (SaveFlags are deprecated) (Closed)

Created:
5 years ago by reed1
Modified:
5 years ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

switch to using SaveLayerFlags (SaveFlags are deprecated) prepares the way for https://codereview.chromium.org/1535993003 BUG= Committed: https://crrev.com/92fb0a65eb5ba36bb6eb55495191f77fcfa6d7d0 Cr-Commit-Position: refs/heads/master@{#366288}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -8 lines) Patch
M skia/ext/benchmarking_canvas.cc View 2 chunks +6 lines, -8 lines 1 comment Download

Messages

Total messages: 11 (5 generated)
reed1
ptal
5 years ago (2015-12-19 17:16:25 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1537203002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1537203002/1
5 years ago (2015-12-19 17:16:36 UTC) #4
f(malita)
lgtm https://codereview.chromium.org/1537203002/diff/1/skia/ext/benchmarking_canvas.cc File skia/ext/benchmarking_canvas.cc (right): https://codereview.chromium.org/1537203002/diff/1/skia/ext/benchmarking_canvas.cc#newcode277 skia/ext/benchmarking_canvas.cc:277: scoped_ptr<base::Value> SaveLayerFlagsAsValue(SkCanvas::SaveLayerFlags flags) { Bummer, we're breaking the ...
5 years ago (2015-12-19 18:09:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1537203002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1537203002/1
5 years ago (2015-12-19 18:09:42 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-20 00:55:05 UTC) #9
commit-bot: I haz the power
5 years ago (2015-12-20 00:57:07 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/92fb0a65eb5ba36bb6eb55495191f77fcfa6d7d0
Cr-Commit-Position: refs/heads/master@{#366288}

Powered by Google App Engine
This is Rietveld 408576698