Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Unified Diff: third_party/WebKit/Source/core/editing/CaretBase.cpp

Issue 1537133002: Renaming: distinguish ancestor, container and paintInvalidationContainer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@SelectionInvalidation
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/frame/FrameView.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/editing/CaretBase.cpp
diff --git a/third_party/WebKit/Source/core/editing/CaretBase.cpp b/third_party/WebKit/Source/core/editing/CaretBase.cpp
index 1ceb458cef692b9dbbc62c848d447bfa089833f2..24b7b494671f2d6f73cfde98d3a63a22d4997bcc 100644
--- a/third_party/WebKit/Source/core/editing/CaretBase.cpp
+++ b/third_party/WebKit/Source/core/editing/CaretBase.cpp
@@ -68,7 +68,7 @@ LayoutBlock* CaretBase::caretLayoutObject(Node* node)
static void mapCaretRectToCaretPainter(LayoutObject* caretLayoutObject, LayoutBlock* caretPainter, LayoutRect& caretRect)
{
// FIXME: This shouldn't be called on un-rooted subtrees.
- // FIXME: This should probably just use mapLocalToContainer.
+ // FIXME: This should probably just use mapLocalToAncestor.
// Compute an offset between the caretLayoutObject and the caretPainter.
ASSERT(caretLayoutObject->isDescendantOf(caretPainter));
@@ -137,7 +137,7 @@ void CaretBase::invalidateLocalCaretRect(Node* node, const LayoutRect& rect)
LayoutRect inflatedRect = rect;
inflatedRect.inflate(1);
- // FIXME: We should use mapLocalToContainer() since we know we're not un-rooted.
+ // FIXME: We should use mapLocalToAncestor() since we know we're not un-rooted.
mapCaretRectToCaretPainter(node->layoutObject(), caretPainter, inflatedRect);
// FIXME: We should not allow paint invalidation out of paint invalidation state. crbug.com/457415
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/frame/FrameView.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698