Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 1537103002: CPDF_QuickStretcher unused. (Closed)

Created:
5 years ago by Tom Sepez
Modified:
5 years ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

CPDF_QuickStretcher unused. Apart from it never being initialized, note that m_status is never set to 1, so the only path that references this class can't be reached. R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/f0f6a01ee3dcb592e4eeaadaa2ea52c2fce317ba

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -202 lines) Patch
M core/include/fpdfapi/fpdf_render.h View 1 chunk +0 lines, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_render/fpdf_render_image.cpp View 5 chunks +0 lines, -179 lines 0 comments Download
M core/src/fpdfapi/fpdf_render/render_int.h View 3 chunks +1 line, -22 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Tom Sepez
Lei, mostly red.
5 years ago (2015-12-18 22:27:05 UTC) #2
Lei Zhang
lgtm Sounds like |m_status| might become an enum in the future?
5 years ago (2015-12-18 22:30:43 UTC) #3
Tom Sepez
5 years ago (2015-12-18 22:33:17 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f0f6a01ee3dcb592e4eeaadaa2ea52c2fce317ba (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698