Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Issue 1537013002: PPC: [runtime] Drop FIRST/LAST_NONCALLABLE_SPEC_OBJECT instance type range. (Closed)

Created:
5 years ago by MTBrandyberry
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: [runtime] Drop FIRST/LAST_NONCALLABLE_SPEC_OBJECT instance type range. Port aafc3e54848af981f02b076cc9cfe7e54a67ad6d Original commit message: The FIRST-LAST_NONCALLABLE_SPEC_OBJECT_TYPE range was accidentially used in field type tracking, where we should check for JSReceiver instead (there's no need to exclude JSProxy or JSFunction from tracking). And the use in %_ClassOf was actually wrong and didn't match the C++ implementation in JSReceiver::class_name() anymore. Now it's consistent again. R=bmeurer@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG=chromium:535408 LOG=n Committed: https://crrev.com/5c33ac6ccd36c846d54aef2a44a6826804ea9a60 Cr-Commit-Position: refs/heads/master@{#32973}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -30 lines) Patch
M src/crankshaft/ppc/lithium-codegen-ppc.cc View 1 chunk +3 lines, -19 lines 0 comments Download
M src/full-codegen/ppc/full-codegen-ppc.cc View 1 chunk +4 lines, -11 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1537013002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1537013002/1
5 years ago (2015-12-18 16:36:46 UTC) #4
MTBrandyberry
5 years ago (2015-12-18 16:36:49 UTC) #5
JoranSiu
On 2015/12/18 16:36:49, mtbrandyberry wrote: lgtm
5 years ago (2015-12-18 17:40:37 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-18 18:33:06 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1537013002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1537013002/1
5 years ago (2015-12-18 19:14:00 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-18 19:15:58 UTC) #11
commit-bot: I haz the power
5 years ago (2015-12-18 19:16:53 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5c33ac6ccd36c846d54aef2a44a6826804ea9a60
Cr-Commit-Position: refs/heads/master@{#32973}

Powered by Google App Engine
This is Rietveld 408576698