Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(689)

Issue 1536893002: Simplify synchronous fetching in WebsitePermissionsFetcher. (Closed)

Created:
5 years ago by newt (away)
Modified:
5 years ago
Reviewers:
Finnur
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Simplify synchronous fetching in WebsitePermissionsFetcher. This makes it easier to implement a synchronous WebsitePermissionsFetcher.Task by simply overriding Task.run(), instead of having to call TaskQueue.next() at the end. Committed: https://crrev.com/7c43624a5f2eeae4d5e6e2b4cfd8ed2ef72618b0 Cr-Commit-Position: refs/heads/master@{#366404}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -47 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/preferences/website/WebsitePermissionsFetcher.java View 5 chunks +43 lines, -47 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
newt (away)
What do you think?
5 years ago (2015-12-18 02:13:57 UTC) #2
Finnur
I'm not against this, but when is a synchronous fetcher needed? Is it for new ...
5 years ago (2015-12-18 10:49:51 UTC) #3
newt (away)
On 2015/12/18 10:49:51, Finnur wrote: > I'm not against this, but when is a synchronous ...
5 years ago (2015-12-18 16:39:04 UTC) #4
Finnur
Ah, yeah. You are right. LGTM.
5 years ago (2015-12-21 09:46:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1536893002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1536893002/1
5 years ago (2015-12-21 16:39:06 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-21 17:28:20 UTC) #8
commit-bot: I haz the power
5 years ago (2015-12-21 17:29:17 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7c43624a5f2eeae4d5e6e2b4cfd8ed2ef72618b0
Cr-Commit-Position: refs/heads/master@{#366404}

Powered by Google App Engine
This is Rietveld 408576698