Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(797)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 153683002: Implement DelegatedFrameResourceCollectionClient::UnusedResourcesAreAvailable for Android. (Closed)

Created:
6 years, 10 months ago by vivekg_samsung
Modified:
6 years, 10 months ago
CC:
chromium-reviews, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, jam, penghuang+watch_chromium.org, joi+watch-content_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, James Su, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Implement DelegatedFrameResourceCollectionClient::UnusedResourcesAreAvailable for Android. Implment UnusedResourcesAreAvailable to send the unused resources back if there are no pending ACKs. Also handle the LoseAllResources from ResourceCollection to send back the resources. R=danakj, sievers Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248892

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -5 lines) Patch
M content/browser/renderer_host/render_widget_host_view_android.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.cc View 1 2 chunks +21 lines, -5 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
vivekg
PTAL, thanks!
6 years, 10 months ago (2014-02-04 10:12:12 UTC) #1
danakj
LGTM https://codereview.chromium.org/153683002/diff/1/content/browser/renderer_host/render_widget_host_view_android.cc File content/browser/renderer_host/render_widget_host_view_android.cc (right): https://codereview.chromium.org/153683002/diff/1/content/browser/renderer_host/render_widget_host_view_android.cc#newcode739 content/browser/renderer_host/render_widget_host_view_android.cc:739: DCHECK(resource_collection_); Would you mind updating the RWHVAura method ...
6 years, 10 months ago (2014-02-04 18:14:37 UTC) #2
vivekg_samsung
The CQ bit was checked by vivek.vg@samsung.com
6 years, 10 months ago (2014-02-04 20:46:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vivek.vg@samsung.com/153683002/70001
6 years, 10 months ago (2014-02-04 21:01:13 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-04 23:11:49 UTC) #5
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=48064
6 years, 10 months ago (2014-02-04 23:11:50 UTC) #6
vivekg_samsung
+piman OWNERS
6 years, 10 months ago (2014-02-05 00:40:34 UTC) #7
vivekg_samsung
+piman OWNERS
6 years, 10 months ago (2014-02-05 00:40:35 UTC) #8
piman
lgtm
6 years, 10 months ago (2014-02-05 00:49:53 UTC) #9
vivekg_samsung
The CQ bit was checked by vivek.vg@samsung.com
6 years, 10 months ago (2014-02-05 00:52:45 UTC) #10
vivekg
The CQ bit was unchecked by vivekg@chromium.org
6 years, 10 months ago (2014-02-05 03:15:44 UTC) #11
vivekg
The CQ bit was checked by vivekg@chromium.org
6 years, 10 months ago (2014-02-05 03:22:19 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vivek.vg@samsung.com/153683002/70001
6 years, 10 months ago (2014-02-05 03:47:35 UTC) #13
commit-bot: I haz the power
6 years, 10 months ago (2014-02-05 07:09:29 UTC) #14
Message was sent while issue was closed. 
Change committed as 248892

Powered by Google App Engine
This is Rietveld 408576698