Improve logging output for DecoderBuffer and VideoFrame

media/cdm/cdm_adapter.cc

Index: media/cdm/cdm_adapter.cc
diff --git a/media/cdm/cdm_adapter.cc b/media/cdm/cdm_adapter.cc
index 0bce8b54d58047b0062ad165e914b77fb0a67603..d4eac5708e8c2bca058c7ccb6b8aec3dd9032197 100644
--- a/media/cdm/cdm_adapter.cc
+++ b/media/cdm/cdm_adapter.cc
@@ -661,6 +661,8 @@ void CdmAdapter::DecryptAndDecodeVideo(
   std::vector<cdm::SubsampleEntry> subsamples;
   scoped_ptr<VideoFrameImpl> video_frame(new VideoFrameImpl());
 
+  DVLOG(5) << __FUNCTION__

[xhwang, 2016/01/05 17:29:11]

Move this to the beginning of this function?

Also, DVLOG(3) should be good here, if we don't log the binary data (see comment
above).

[jrummell, 2016/01/12 20:00:36]

Done.

+           << " encrypted: " << encrypted->AsHumanReadableString();
   ToCdmInputBuffer(encrypted, &subsamples, &input_buffer);
   cdm::Status status =
       cdm_->DecryptAndDecodeFrame(input_buffer, video_frame.get());
@@ -682,6 +684,8 @@ void CdmAdapter::DecryptAndDecodeVideo(
       frame_data + video_frame->PlaneOffset(VideoFrameImpl::kUPlane),
       frame_data + video_frame->PlaneOffset(VideoFrameImpl::kVPlane),
       base::TimeDelta::FromMicroseconds(video_frame->Timestamp()));
+  DVLOG(5) << __FUNCTION__
+           << " decoded_frame: " << decoded_frame->AsHumanReadableString();

[xhwang, 2016/01/05 17:29:11]

We have only 5 cases of DVLOG(5) in the entire code base, which makes me feel we
shouldn't use DVLOG(5) for logs that are less useful. In this particular case,
this log is only useful when we have bugs in converting VideoFrames. After we
fix the bug, we probably never need this log anymore. So instead of having a
DVLOG(5) here, maybe we should only add it temporarily during debug when we need
it? 

[jrummell, 2016/01/12 20:00:36]

Done.

   video_decode_cb.Run(Decryptor::kSuccess, decoded_frame);
 }