Improve logging output for DecoderBuffer and VideoFrame

media/base/decoder_buffer.cc

Index: media/base/decoder_buffer.cc
diff --git a/media/base/decoder_buffer.cc b/media/base/decoder_buffer.cc
index 613e094d7e461c5cc614e3180ecfa5d6d1c06e3e..24f2088d524c8fb94f57417a2ac23d2dd45af777 100644
--- a/media/base/decoder_buffer.cc
+++ b/media/base/decoder_buffer.cc
@@ -4,6 +4,8 @@
 
 #include "media/base/decoder_buffer.h"
 
+#include "base/strings/string_number_conversions.h"
+
 namespace media {
 
 // Allocates a block of memory which is padded for use with the SIMD
@@ -89,13 +91,21 @@ std::string DecoderBuffer::AsHumanReadableString() {
 
   std::ostringstream s;
   s << "timestamp: " << timestamp_.InMicroseconds()
-    << " duration: " << duration_.InMicroseconds()
-    << " size: " << size_
-    << " side_data_size: " << side_data_size_
+    << " duration: " << duration_.InMicroseconds() << " size: " << size_
+    << " data: ";
+  if (size_ == 0 || !data_)
+    s << "<null>";
+  else if (size_ < 17)
+    s << base::HexEncode(data_.get(), size_);
+  else {
+    s << base::HexEncode(data_.get(), 8) << "..."
+      << base::HexEncode(data_.get() + size_ - 8, 8);

[xhwang, 2016/01/05 17:29:11]

I still don't see a general use case for dumping the binary data. Note that
AsHumanReadableString() is a generic function and can be used in a lot of
places, most of which won't be interested in the binary data. 

When in the rare cases where we are actually interested, we can always manually
dump the binary data.

[jrummell, 2016/01/12 20:00:36]

Done.

+  }
+  s << " side_data_size: " << side_data_size_
     << " is_key_frame: " << is_key_frame_
-    << " encrypted: " << (decrypt_config_ != NULL)
-    << " discard_padding (ms): (" << discard_padding_.first.InMilliseconds()
-    << ", " << discard_padding_.second.InMilliseconds() << ")";
+    << " encrypted: " << (decrypt_config_ != NULL) << " discard_padding (ms): ("
+    << discard_padding_.first.InMilliseconds() << ", "
+    << discard_padding_.second.InMilliseconds() << ")";
 
   if (decrypt_config_)
     s << " decrypt:" << (*decrypt_config_);