Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 1536773003: add include files from llvm used by subzero into doxygen (Closed)

Created:
5 years ago by rkotlerimgtec
Modified:
5 years ago
CC:
native-client-reviews_googlegroups.com, rich.fuhler_imgtec.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

add include files from llvm used by subzero into doxygen this fixes a lot of problems with the doxygen. for example with this, now doxygen correctly understands the cl::opt variables in ClFlags.cpp as variables, whereas previously it thought they were functions. it's possible to make the llvm includes more selective but this is a good first cut and better than including all of llvm includes. BUG= R=stichnot@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=3e0cda2b685be87a3a918fea6ba83dcf21087c6e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -4 lines) Patch
M Doxyfile View 4 chunks +10 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
rkotlerimgtec
5 years ago (2015-12-17 23:12:21 UTC) #4
Jim Stichnoth
lgtm
5 years ago (2015-12-18 00:33:28 UTC) #5
Jim Stichnoth
5 years ago (2015-12-18 00:34:07 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3e0cda2b685be87a3a918fea6ba83dcf21087c6e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698