Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(929)

Issue 1536733002: Deprecate initTouchEvent (Closed)

Created:
5 years ago by chongz
Modified:
5 years ago
Reviewers:
dtapuska, Rick Byers
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Deprecate initTouchEvent Document.initTouchEvent is not standardized and not interoperate with Firefox or Safari. Developers should be encouraged to use new TouchEvent constructor instead. To be removed in M53 BUG=522100 Intent to Deprecate and Remove: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/dqlJguVuIHs Related: http://crrev.com/1410833006 Committed: https://crrev.com/0a4b585a8dcf0a4311b5a06023b43c337c321404 Cr-Commit-Position: refs/heads/master@{#366484}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Fixed layout tests #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -14 lines) Patch
M third_party/WebKit/LayoutTests/fast/events/touch/document-create-touch-list-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/events/touch/touch-event-dispatch-no-crash-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/events/TouchEvent.idl View 1 1 chunk +13 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.cpp View 1 2 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
chongz
Can I have a review about this deprecation please? Although deprecation doesn't seem require formal ...
5 years ago (2015-12-17 21:47:52 UTC) #3
Rick Byers
LGTM with nits nit: please update the summary / lalbels on the bug to indicate ...
5 years ago (2015-12-18 17:16:10 UTC) #4
chongz
https://codereview.chromium.org/1536733002/diff/1/third_party/WebKit/Source/core/events/TouchEvent.idl File third_party/WebKit/Source/core/events/TouchEvent.idl (right): https://codereview.chromium.org/1536733002/diff/1/third_party/WebKit/Source/core/events/TouchEvent.idl#newcode39 third_party/WebKit/Source/core/events/TouchEvent.idl:39: // FIXME: initTouchEvent() is not standardized. http://crbug.com/518868 On 2015/12/18 ...
5 years ago (2015-12-21 22:54:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1536733002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1536733002/80001
5 years ago (2015-12-21 22:55:28 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:80001)
5 years ago (2015-12-21 23:04:24 UTC) #12
commit-bot: I haz the power
5 years ago (2015-12-21 23:05:09 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/0a4b585a8dcf0a4311b5a06023b43c337c321404
Cr-Commit-Position: refs/heads/master@{#366484}

Powered by Google App Engine
This is Rietveld 408576698