Deprecate initTouchEvent

Deprecate initTouchEvent

Document.initTouchEvent is not standardized and not interoperate with
Firefox or Safari. Developers should be encouraged to use new TouchEvent
constructor instead.

To be removed in M53

BUG=522100
Intent to Deprecate and Remove:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/dqlJguVuIHs

Related:
http://crrev.com/1410833006

Committed: https://crrev.com/0a4b585a8dcf0a4311b5a06023b43c337c321404
Cr-Commit-Position: refs/heads/master@{#366484}

[chongz, 2015-12-17 18:21:44]

Description was changed from

==========
Deprecate initTouchEvent


Document.initTouchEvent is not standardized and not interoperate with
Firefox or Safari. Developers should be encouraged to use new TouchEvent
constructor instead.

To be removed in M53

BUG=522100

Intent to Deprecate and Remove:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/dqlJguVuIHs
==========

to

==========
Deprecate initTouchEvent


Document.initTouchEvent is not standardized and not interoperate with
Firefox or Safari. Developers should be encouraged to use new TouchEvent
constructor instead.

To be removed in M53

BUG=522100

Intent to Deprecate and Remove:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/dqlJguVuIHs

Related:
http://crrev.com/1410833006
==========

[chongz, 2015-12-17 18:22:08]

chongz@chromium.org changed reviewers:
+ dtapuska@chromium.org, rbyers@chromium.org

[chongz, 2015-12-17 21:47:52]

Can I have a review about this deprecation please?
Although deprecation doesn't seem require formal approval according to
http://www.chromium.org/blink#TOC-Launch-Process:-Deprecation

[Rick Byers, 2015-12-18 17:16:10]

LGTM with nits

nit: please update the summary / lalbels on the bug to indicate this is now a
removal of initTouchEvent

https://codereview.chromium.org/1536733002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/events/TouchEvent.idl (right):

https://codereview.chromium.org/1536733002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/events/TouchEvent.idl:39: // FIXME:
initTouchEvent() is not standardized. http://crbug.com/518868
Nit: might as well remove this FIXME - marking it as deprecated means we intent
to remove it.

https://codereview.chromium.org/1536733002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/frame/UseCounter.cpp (right):

https://codereview.chromium.org/1536733002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/frame/UseCounter.cpp:944: return
"'TouchEvent.initTouchEvent' is deprecated and will be removed in M53, around
September 2016. Please use TouchEvent constructor instead. See
https://www.chromestatus.com/features/5730982598541312 for more details.";
nit: s/use TouchEvent constructor/use the TouchEvent constructor/

Also please update your chromestatus entry to link directly to our constructor
demo page: https://jsbin.com/lohuwa (and perhaps also the spec example I just
added:
https://w3c.github.io/touch-events/#firing-a-synthetic-touchevent-from-script)

[chongz, 2015-12-18 22:38:08]

Patchset #3 (id:40001) has been deleted

[chongz, 2015-12-18 22:38:40]

Patchset #2 (id:20001) has been deleted

[chongz, 2015-12-21 22:54:34]

https://codereview.chromium.org/1536733002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/events/TouchEvent.idl (right):

https://codereview.chromium.org/1536733002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/events/TouchEvent.idl:39: // FIXME:
initTouchEvent() is not standardized. http://crbug.com/518868
On 2015/12/18 17:16:10, Rick Byers wrote:
> Nit: might as well remove this FIXME - marking it as deprecated means we
intent
> to remove it.

Done.

https://codereview.chromium.org/1536733002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/frame/UseCounter.cpp (right):

https://codereview.chromium.org/1536733002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/frame/UseCounter.cpp:944: return
"'TouchEvent.initTouchEvent' is deprecated and will be removed in M53, around
September 2016. Please use TouchEvent constructor instead. See
https://www.chromestatus.com/features/5730982598541312 for more details.";
On 2015/12/18 17:16:10, Rick Byers wrote:
> nit: s/use TouchEvent constructor/use the TouchEvent constructor/
> 
> Also please update your chromestatus entry to link directly to our constructor
> demo page: https://jsbin.com/lohuwa (and perhaps also the spec example I just
> added:
> https://w3c.github.io/touch-events/#firing-a-synthetic-touchevent-from-script)

Done.

[chongz, 2015-12-21 22:54:46]

The CQ bit was checked by chongz@chromium.org

[chongz, 2015-12-21 22:54:47]

The patchset sent to the CQ was uploaded after l-g-t-m from rbyers@chromium.org
Link to the patchset: https://codereview.chromium.org/1536733002/#ps80001
(title: "Rebase")

[commit-bot: I haz the power, 2015-12-21 22:55:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1536733002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1536733002/80001

[commit-bot: I haz the power, 2015-12-21 23:04:23]

Description was changed from

==========
Deprecate initTouchEvent


Document.initTouchEvent is not standardized and not interoperate with
Firefox or Safari. Developers should be encouraged to use new TouchEvent
constructor instead.

To be removed in M53

BUG=522100

Intent to Deprecate and Remove:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/dqlJguVuIHs

Related:
http://crrev.com/1410833006
==========

to

==========
Deprecate initTouchEvent


Document.initTouchEvent is not standardized and not interoperate with
Firefox or Safari. Developers should be encouraged to use new TouchEvent
constructor instead.

To be removed in M53

BUG=522100

Intent to Deprecate and Remove:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/dqlJguVuIHs

Related:
http://crrev.com/1410833006
==========

[commit-bot: I haz the power, 2015-12-21 23:04:24]

Committed patchset #3 (id:80001)

[commit-bot: I haz the power, 2015-12-21 23:05:08]

Description was changed from

==========
Deprecate initTouchEvent


Document.initTouchEvent is not standardized and not interoperate with
Firefox or Safari. Developers should be encouraged to use new TouchEvent
constructor instead.

To be removed in M53

BUG=522100

Intent to Deprecate and Remove:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/dqlJguVuIHs

Related:
http://crrev.com/1410833006
==========

to

==========
Deprecate initTouchEvent

Document.initTouchEvent is not standardized and not interoperate with
Firefox or Safari. Developers should be encouraged to use new TouchEvent
constructor instead.

To be removed in M53

BUG=522100

Intent to Deprecate and Remove:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/dqlJguVuIHs

Related:
http://crrev.com/1410833006

Committed: https://crrev.com/0a4b585a8dcf0a4311b5a06023b43c337c321404
Cr-Commit-Position: refs/heads/master@{#366484}
==========

[commit-bot: I haz the power, 2015-12-21 23:05:09]

Patchset 3 (id:??) landed as
https://crrev.com/0a4b585a8dcf0a4311b5a06023b43c337c321404
Cr-Commit-Position: refs/heads/master@{#366484}