[MIPS] Make $t8 point to the address of TLS pointers

[MIPS] Make $t8 point to the address of TLS pointers

Modify sel_ldr to hold values for user code tls and IRT tls.
Let tls_edit modify the binary for IRT code.

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4345

Committed: https://chromium.googlesource.com/native_client/src/native_client/+/b44e8dc36b2d34a1c2d5b4c13913ae276551252a

[petarj, 2015-12-17 19:39:03]

Description was changed from

==========
[MIPS] Make $t8 point to the address of TLS pointers

Modify sel_ldr to hold values for user code tls and IRT tls.
Let tls_edit modify the binary for IRT code.

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4345
==========

to

==========
[MIPS] Make $t8 point to the address of TLS pointers

Modify sel_ldr to hold values for user code tls and IRT tls.
Let tls_edit modify the binary for IRT code.

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4345
==========

[petarj, 2015-12-17 19:39:03]

petarj@mips.com changed reviewers:
+ dschuff@chromium.org, mseaborn@chromium.org

[petarj, 2015-12-17 19:39:55]

PTAL.

[petarj, 2015-12-22 14:06:59]

ping.

[petarj, 2015-12-30 01:33:43]

Any comments here?

[Mark Seaborn, 2015-12-30 02:21:36]

On 2015/12/30 01:33:43, petarj wrote:
> Any comments here?

Presumably this change isn't safe until your other change,
https://codereview.chromium.org/1535443005/, is committed?

[petarj, 2015-12-30 17:12:38]

On 2015/12/30 02:21:36, Mark Seaborn wrote:
> On 2015/12/30 01:33:43, petarj wrote:
> > Any comments here?
> 
> Presumably this change isn't safe until your other change,
> https://codereview.chromium.org/1535443005/, is committed?

Well, all these changes depend one on each other, so yes, it is not
safe without it.

[Mark Seaborn, 2016-01-11 22:19:28]

LGTM

https://codereview.chromium.org/1536713003/diff/1/src/tools/tls_edit/tls_edit.c
File src/tools/tls_edit/tls_edit.c (right):

https://codereview.chromium.org/1536713003/diff/1/src/tools/tls_edit/tls_edit...
src/tools/tls_edit/tls_edit.c:43: static void EditMipsCode(void *code, size_t
code_length) {
Nit: can you order this after EditArmCode()?

[petarj, 2016-01-11 23:21:38]

https://codereview.chromium.org/1536713003/diff/1/src/tools/tls_edit/tls_edit.c
File src/tools/tls_edit/tls_edit.c (right):

https://codereview.chromium.org/1536713003/diff/1/src/tools/tls_edit/tls_edit...
src/tools/tls_edit/tls_edit.c:43: static void EditMipsCode(void *code, size_t
code_length) {
On 2016/01/11 22:19:28, Mark Seaborn wrote:
> Nit: can you order this after EditArmCode()?

Done.

[petarj, 2016-01-12 00:34:37]

The CQ bit was checked by petarj@mips.com

[petarj, 2016-01-12 00:34:37]

The patchset sent to the CQ was uploaded after l-g-t-m from
mseaborn@chromium.org
Link to the patchset: https://codereview.chromium.org/1536713003/#ps20001
(title: "Move EditMipsCode() below EditArmCode().")

[commit-bot: I haz the power, 2016-01-12 00:34:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1536713003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1536713003/20001

[commit-bot: I haz the power, 2016-01-12 01:29:41]

Description was changed from

==========
[MIPS] Make $t8 point to the address of TLS pointers

Modify sel_ldr to hold values for user code tls and IRT tls.
Let tls_edit modify the binary for IRT code.

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4345
==========

to

==========
[MIPS] Make $t8 point to the address of TLS pointers

Modify sel_ldr to hold values for user code tls and IRT tls.
Let tls_edit modify the binary for IRT code.

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4345

Committed:
https://chromium.googlesource.com/native_client/src/native_client/+/b44e8dc36...
==========

[commit-bot: I haz the power, 2016-01-12 01:29:41]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/native_client/src/native_client/+/b44e8dc36...