Move webkit/database to webkit/browser and webkit/common.

Move webkit/database to webkit/browser and webkit/common. Also move content::WebDatabaseObserverImpl to the new common_child library.
- just moving the files in the source repository
- and fixing up complilation guards
- and fixing up include paths throughout
- and fixing up DEPs files as needed
Note: Everything in /webkit is still being built into the same old webkit_storage target
for now, new actual build target(s) will come later.

BUG=239109
R=jamesr@chromium.org, kinuko@chromium.org, piman@chromium.org, thestig@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=201619

[michaeln, 2013-05-21 01:25:30]

running some try jobs to find out what i've missed

https://codereview.chromium.org/15367010/diff/10012/content/common/web_databa...
File content/common/web_database_observer_impl.h (right):

https://codereview.chromium.org/15367010/diff/10012/content/common/web_databa...
content/common/web_database_observer_impl.h:15: // TODO(michaeln): move this
class to content/child_common (crbug 239109)
Looks like jamesr's CL is landing, i'll do this in the CL too.

https://codereview.chromium.org/15367010/diff/10012/webkit/renderer/composito...
File webkit/renderer/compositor_bindings/web_layer_tree_view_impl_for_testing.cc
(right):

https://codereview.chromium.org/15367010/diff/10012/webkit/renderer/composito...
webkit/renderer/compositor_bindings/web_layer_tree_view_impl_for_testing.cc:38:
// (a non-testing lib)
I want to understand wassup with this file? It pulls in
test_webkit_platform_support.h which in turn pulls in the gammut of
test_shell/simple* classes.

I can see that webkit_compositor_bindings lib is needed for 'content' proper,
but this class maybe could be picked up by a test target separately.

[jamesr, 2013-05-21 01:59:04]

https://codereview.chromium.org/15367010/diff/33002/webkit/renderer/composito...
File webkit/renderer/compositor_bindings/web_layer_tree_view_impl_for_testing.cc
(right):

https://codereview.chromium.org/15367010/diff/33002/webkit/renderer/composito...
webkit/renderer/compositor_bindings/web_layer_tree_view_impl_for_testing.cc:37:
// TODO(michaeln): why is this being built into the content_lib?
this class exists only for DumpRenderTree and webkit_unit_tests. It really
should be linked into a test library linked into webkit_support, probably as a
static lib.  It probably could just be linked into webkit_support as well. 
Filed https://code.google.com/p/chromium/issues/detail?id=242404 on myself to
fix this - feel free to make this TODO(jamesr) with a link to that bug.

We should really add DEPS rules to ban webkit/support #includes from stuff
outside of webkit/support

[jamesr, 2013-05-21 07:26:40]

It looks like you still have some #includes to track down to get this compiling
everywhere, but lgtm once you get the trybots happy.

https://codereview.chromium.org/15367010/diff/33002/webkit/dom_storage/dom_st...
File webkit/dom_storage/dom_storage_area.cc (right):

https://codereview.chromium.org/15367010/diff/33002/webkit/dom_storage/dom_st...
webkit/dom_storage/dom_storage_area.cc:16: #include
"webkit/browser/database/database_util.h"
I guess this implies that dom_storage is moving into webkit/browser/ too at some
point, right?

[kinuko, 2013-05-21 07:55:35]

lgtm2 with same comments as jamesr.  Jfyi, as for include fixups
tools/git/move_source_file.py worked greatly for me.

[michaeln, 2013-05-21 20:35:36]

Looking at the build errors and moving the WebKitAPI derivative, will have a new
patch soon'ish.

> I guess this implies that dom_storage is moving into webkit/browser/

yes, of course... and blob and appcache and and and...

> tools/git/move_source_file.py worked greatly for me.

thnx for the ptr to the tool, i'll take a look

[michaeln, 2013-05-22 01:23:52]

New snapshot with fixed up includes and to also move
content::WebDatabaseObserverImpl to the common_child library.

https://codereview.chromium.org/15367010/diff/72001/content/common_child/web_...
File content/common_child/web_database_observer_impl.cc (right):

https://codereview.chromium.org/15367010/diff/72001/content/common_child/web_...
content/common_child/web_database_observer_impl.cc:5: #include
"content/common_child/web_database_observer_impl.h"
Updated to also move this WebKitAPI derivative into the common_child lib.

[michaeln, 2013-05-22 20:37:28]

woot... trybots are happy

@piman for /content
@thestig for /chrome

[Lei Zhang, 2013-05-22 20:47:43]

We discussed with kinuko on a similar CL, you can just TBR.

[Lei Zhang, 2013-05-22 20:48:08]

and chrome/ lgtm

[michaeln, 2013-05-22 20:51:53]

On 2013/05/22 20:48:08, Lei Zhang wrote:
> and chrome/ lgtm

thnx, i have some updating todo (getting collisions on these gypi and DEPs
changes with some many moves in the air)

[piman, 2013-05-22 21:40:40]

lgtm

[michaeln, 2013-05-22 22:02:42]

Committed patchset #13 manually as r201619 (presubmit successful).