Create a mirror window.

This CL create just a window which will be used to show 
the mirrored content of the source window. See the next steps
for 

misc:
* added debug+desktop only shortcut 
* rotating square display now update the root window. 

Next steps:
* Mirror cursor
* Modify OutputConfigurator to fallback to software mirror mode.
* Scale the root window size for mirror window so that 
it has the same size as the source root window. 
* Copy texture from soruce window to dest window. 
* Handle device scale factor/cursor scaling. 

BUG=239776
TEST=covered by test

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=201618

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=201870

[Jun Mukai, 2013-05-20 21:58:58]

lgtm

[oshima, 2013-05-20 22:14:40]

jamescook -> ash/

[James Cook, 2013-05-20 22:52:18]

On 2013/05/20 22:14:40, oshima wrote:
> jamescook -> ash/

I need to head home now, will take a look at this either late tonight or early
tomorrow.

[James Cook, 2013-05-21 08:07:41]

LGTM assuming comments addressed

https://codereview.chromium.org/15367003/diff/11002/ash/display/display_manag...
File ash/display/display_manager.cc (right):

https://codereview.chromium.org/15367003/diff/11002/ash/display/display_manag...
ash/display/display_manager.cc:130: class MirrorWindowCreater : public
MirrorWindowUpdater {
nit: either Creator or Builder

https://codereview.chromium.org/15367003/diff/11002/ash/display/display_manag...
ash/display/display_manager.cc:445: new
MirrorWindowCreater(display_info_[new_info_iter->id()]));
Does this need to choose the higher resolution monitor as the source?

https://codereview.chromium.org/15367003/diff/11002/ash/display/display_manag...
File ash/display/display_manager_unittest.cc (right):

https://codereview.chromium.org/15367003/diff/11002/ash/display/display_manag...
ash/display/display_manager_unittest.cc:854: TEST_F(DisplayManagerTest,
SoftwareMirroring) {
Hooray, new code has a new test!

https://codereview.chromium.org/15367003/diff/11002/ash/display/mirror_window...
File ash/display/mirror_window_controller.cc (right):

https://codereview.chromium.org/15367003/diff/11002/ash/display/mirror_window...
ash/display/mirror_window_controller.cc:40:
XSelectInput(base::MessagePumpAuraX11::GetDefaultXDisplay(),
Comment this? Is it disabling input by selecting only the flags but not
mouse/keyboard events?

https://codereview.chromium.org/15367003/diff/11002/ash/display/mirror_window...
ash/display/mirror_window_controller.cc:175:
aura::client::GetCaptureClient(root_window_.get()));
Do you also need to SetCaptureClient() to NONE, or is that handled in the
destructor for root_window_?

https://codereview.chromium.org/15367003/diff/11002/ash/display/mirror_window...
ash/display/mirror_window_controller.cc:187: bounds.set_origin(point); // use
hot point.
Two spaces before "// Use hot point."

https://codereview.chromium.org/15367003/diff/11002/ash/display/mirror_window...
File ash/display/mirror_window_controller.h (right):

https://codereview.chromium.org/15367003/diff/11002/ash/display/mirror_window...
ash/display/mirror_window_controller.h:33: // Updates the root window's bounds
using |dispaly_info|.
dispaly_info -> display_info

https://codereview.chromium.org/15367003/diff/11002/ash/shell.h
File ash/shell.h (right):

https://codereview.chromium.org/15367003/diff/11002/ash/shell.h#newcode579
ash/shell.h:579: scoped_ptr<internal::MirrorWindowController>
mirror_window_controller_;
Comment what this is.

[oshima, 2013-05-21 14:41:50]

https://codereview.chromium.org/15367003/diff/11002/ash/display/display_manag...
File ash/display/display_manager.cc (right):

https://codereview.chromium.org/15367003/diff/11002/ash/display/display_manag...
ash/display/display_manager.cc:130: class MirrorWindowCreater : public
MirrorWindowUpdater {
On 2013/05/21 08:07:41, James Cook (Chromium) wrote:
> nit: either Creator or Builder

Done.

https://codereview.chromium.org/15367003/diff/11002/ash/display/display_manag...
ash/display/display_manager.cc:445: new
MirrorWindowCreater(display_info_[new_info_iter->id()]));
On 2013/05/21 08:07:41, James Cook (Chromium) wrote:
> Does this need to choose the higher resolution monitor as the source?

Considering the typical usage, I think this should be external display,
but we need to discuss it. I have TODO above.

https://codereview.chromium.org/15367003/diff/11002/ash/display/mirror_window...
File ash/display/mirror_window_controller.cc (right):

https://codereview.chromium.org/15367003/diff/11002/ash/display/mirror_window...
ash/display/mirror_window_controller.cc:40:
XSelectInput(base::MessagePumpAuraX11::GetDefaultXDisplay(),
On 2013/05/21 08:07:41, James Cook (Chromium) wrote:
> Comment this? Is it disabling input by selecting only the flags but not
> mouse/keyboard events?

I think it's pretty clear from the method name, and also from the impl. I added
why it needs to disable input instead though.

https://codereview.chromium.org/15367003/diff/11002/ash/display/mirror_window...
ash/display/mirror_window_controller.cc:175:
aura::client::GetCaptureClient(root_window_.get()));
On 2013/05/21 08:07:41, James Cook (Chromium) wrote:
> Do you also need to SetCaptureClient() to NONE, or is that handled in the
> destructor for root_window_?

No, it's not owned by RootWindow.

https://codereview.chromium.org/15367003/diff/11002/ash/display/mirror_window...
ash/display/mirror_window_controller.cc:187: bounds.set_origin(point); // use
hot point.
On 2013/05/21 08:07:41, James Cook (Chromium) wrote:
> Two spaces before "// Use hot point."

This was reminder for myself, which I forgot to remove. Thank you for catching.
Removed.

https://codereview.chromium.org/15367003/diff/11002/ash/display/mirror_window...
File ash/display/mirror_window_controller.h (right):

https://codereview.chromium.org/15367003/diff/11002/ash/display/mirror_window...
ash/display/mirror_window_controller.h:33: // Updates the root window's bounds
using |dispaly_info|.
On 2013/05/21 08:07:41, James Cook (Chromium) wrote:
> dispaly_info -> display_info

Done.

https://codereview.chromium.org/15367003/diff/11002/ash/shell.h
File ash/shell.h (right):

https://codereview.chromium.org/15367003/diff/11002/ash/shell.h#newcode579
ash/shell.h:579: scoped_ptr<internal::MirrorWindowController>
mirror_window_controller_;
On 2013/05/21 08:07:41, James Cook (Chromium) wrote:
> Comment what this is.

I added the comment to the mirror window controller.h
This is only place this class is used, so it's better to be there.

[commit-bot: I haz the power, 2013-05-21 14:43:06]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/oshima@chromium.org/15367003/22001

[commit-bot: I haz the power, 2013-05-21 22:22:45]

Retried try job too often on win7_aura for step(s) ash_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&...

[commit-bot: I haz the power, 2013-05-22 14:57:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/oshima@chromium.org/15367003/37001

[commit-bot: I haz the power, 2013-05-22 20:37:06]

Step "update" is always a major failure.
Look at the try server FAQ for more details.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2013-05-22 21:20:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/oshima@chromium.org/15367003/37001

[commit-bot: I haz the power, 2013-05-22 22:01:56]

Change committed as 201618

[commit-bot: I haz the power, 2013-05-23 11:27:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/oshima@chromium.org/15367003/70001

[commit-bot: I haz the power, 2013-05-23 18:15:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/oshima@chromium.org/15367003/70001

[commit-bot: I haz the power, 2013-05-23 19:58:41]

Change committed as 201870