Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 1536683003: remove unused DartCompletionCache (Closed)

Created:
5 years ago by danrubel
Modified:
5 years ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -387 lines) Patch
D pkg/analysis_server/lib/src/services/completion/dart_completion_cache.dart View 1 chunk +0 lines, -358 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart View 6 chunks +7 lines, -27 lines 0 comments Download
M pkg/analysis_server/test/services/completion/dart/common_usage_sorter_test.dart View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
danrubel
5 years ago (2015-12-17 15:19:55 UTC) #2
scheglov
LGTM
5 years ago (2015-12-17 15:51:52 UTC) #3
danrubel
5 years ago (2015-12-17 15:58:52 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
6d5efd3175140b4ddfbc00da72eb38608aea5cb2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698