Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutBlockFlowLine.cpp

Issue 1536663004: Need to repaint its ::first-line background when a block moves. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Two tests even need manual rebaseline, since they already existed in TestExpectations. Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutBlockFlow.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2000 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 2000 Lars Knoll (knoll@kde.org)
3 * Copyright (C) 2003, 2004, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ight reserved. 3 * Copyright (C) 2003, 2004, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ight reserved.
4 * Copyright (C) 2010 Google Inc. All rights reserved. 4 * Copyright (C) 2010 Google Inc. All rights reserved.
5 * 5 *
6 * This library is free software; you can redistribute it and/or 6 * This library is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU Library General Public 7 * modify it under the terms of the GNU Library General Public
8 * License as published by the Free Software Foundation; either 8 * License as published by the Free Software Foundation; either
9 * version 2 of the License, or (at your option) any later version. 9 * version 2 of the License, or (at your option) any later version.
10 * 10 *
(...skipping 2061 matching lines...) Expand 10 before | Expand all | Expand 10 after
2072 return logicalLeft; 2072 return logicalLeft;
2073 } 2073 }
2074 2074
2075 void LayoutBlockFlow::invalidateDisplayItemClientsOfFirstLine() 2075 void LayoutBlockFlow::invalidateDisplayItemClientsOfFirstLine()
2076 { 2076 {
2077 ASSERT(childrenInline()); 2077 ASSERT(childrenInline());
2078 if (RootInlineBox* firstRootBox = this->firstRootBox()) 2078 if (RootInlineBox* firstRootBox = this->firstRootBox())
2079 firstRootBox->invalidateDisplayItemClientsRecursively(); 2079 firstRootBox->invalidateDisplayItemClientsRecursively();
2080 } 2080 }
2081 2081
2082 PaintInvalidationReason LayoutBlockFlow::invalidatePaintIfNeeded(PaintInvalidati onState& paintInvalidationState, const LayoutBoxModelObject& paintInvalidationCo ntainer)
2083 {
2084 PaintInvalidationReason reason = LayoutBlock::invalidatePaintIfNeeded(paintI nvalidationState, paintInvalidationContainer);
2085 if (reason == PaintInvalidationNone)
2086 return reason;
2087 RootInlineBox* line = firstRootBox();
2088 if (!line || !line->isFirstLineStyle())
2089 return reason;
2090 // It's the RootInlineBox that paints the ::first-line background. Note that since it may be
2091 // expensive to figure out if the first line is affected by any ::first-line selectors at all,
2092 // we just invalidate it unconditionally, since that's typically cheaper.
2093 invalidateDisplayItemClient(*line);
2094 return reason;
2082 } 2095 }
2096
2097 }
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutBlockFlow.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698