Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1536663002: Fixing more wasm warnings. (Closed)

Created:
5 years ago by bradn
Modified:
5 years ago
Reviewers:
ahaas
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fixing more wasm warnings. R=ahaas@chromium.org BUG= Committed: https://crrev.com/d9ffa30563e9510bcf231513083fdd10168c2d97 Cr-Commit-Position: refs/heads/master@{#32952}

Patch Set 1 #

Patch Set 2 : drop #

Patch Set 3 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -9 lines) Patch
M src/wasm/asm-wasm-builder.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M src/wasm/wasm-opcodes.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M test/cctest/wasm/test-run-wasm.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
bradn
5 years ago (2015-12-17 13:41:08 UTC) #1
bradn
5 years ago (2015-12-17 14:08:47 UTC) #3
ahaas
lgtm
5 years ago (2015-12-17 14:10:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1536663002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1536663002/40001
5 years ago (2015-12-17 14:10:57 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years ago (2015-12-17 14:55:06 UTC) #8
commit-bot: I haz the power
5 years ago (2015-12-17 14:55:25 UTC) #10
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/d9ffa30563e9510bcf231513083fdd10168c2d97
Cr-Commit-Position: refs/heads/master@{#32952}

Powered by Google App Engine
This is Rietveld 408576698