Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(585)

Unified Diff: components/autofill/content/renderer/password_autofill_agent.cc

Issue 1536653002: Fix saving password in Password Manager on nytimes.com. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Small renaming Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/autofill/content/renderer/password_autofill_agent.cc
diff --git a/components/autofill/content/renderer/password_autofill_agent.cc b/components/autofill/content/renderer/password_autofill_agent.cc
index ca9117b8c840eb7c62570773978a9dd122f602b2..de716bc2fc51f9e05f5670dc60e47fb231b33a43 100644
--- a/components/autofill/content/renderer/password_autofill_agent.cc
+++ b/components/autofill/content/renderer/password_autofill_agent.cc
@@ -1053,16 +1053,10 @@ void PasswordAutofillAgent::SendPasswordForms(bool only_visible) {
}
if (only_visible) {
- bool is_last_load = true;
- for (blink::WebFrame* frame = render_frame()->GetWebFrame()->top(); frame;
- frame = frame->traverseNext(false)) {
- if (frame != render_frame()->GetWebFrame() && frame->isLoading()) {
- is_last_load = false;
- break;
- }
- }
+ blink::WebFrame* main_frame = render_frame()->GetWebFrame()->top();
+ bool did_stop_loading = !main_frame || !main_frame->isLoading();
Send(new AutofillHostMsg_PasswordFormsRendered(routing_id(), password_forms,
- is_last_load));
+ did_stop_loading));
} else {
Send(new AutofillHostMsg_PasswordFormsParsed(routing_id(), password_forms));
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698