Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 153663002: Files.app: Clear the sync message after completion. (Closed)

Created:
6 years, 10 months ago by hirono
Modified:
6 years, 10 months ago
Reviewers:
mtomasz
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, arv+watch_chromium.org
Visibility:
Public.

Description

Files.app: Clear the sync message after completion. Previously, if the sync took a time, the message never disappeared. This was caused by drop of the callback() invokation in AsyncUtil.Queue. This CL fixes it. BUG=340419 TEST=manually Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248864

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -15 lines) Patch
M chrome/browser/resources/file_manager/background/js/drive_sync_handler.js View 1 chunk +17 lines, -15 lines 0 comments Download

Messages

Total messages: 19 (0 generated)
hirono
PTAL the CL? Thanks!
6 years, 10 months ago (2014-02-04 09:13:06 UTC) #1
mtomasz
lgtm, sorry for not catching earlier!
6 years, 10 months ago (2014-02-04 09:56:56 UTC) #2
hirono
The CQ bit was checked by hirono@chromium.org
6 years, 10 months ago (2014-02-04 10:17:08 UTC) #3
hirono
On 2014/02/04 09:56:56, mtomasz wrote: > lgtm, sorry for not catching earlier! Thanks!
6 years, 10 months ago (2014-02-04 10:17:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hirono@chromium.org/153663002/1
6 years, 10 months ago (2014-02-04 10:17:55 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-04 10:59:50 UTC) #6
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) base_unittests, browser_tests, interactive_ui_tests, net_unittests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=223039
6 years, 10 months ago (2014-02-04 10:59:51 UTC) #7
hirono
The CQ bit was checked by hirono@chromium.org
6 years, 10 months ago (2014-02-04 12:36:37 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hirono@chromium.org/153663002/1
6 years, 10 months ago (2014-02-04 12:37:44 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-04 13:35:44 UTC) #10
commit-bot: I haz the power
Retried try job too often on ios_dbg_simulator for step(s) url_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_simulator&number=120753
6 years, 10 months ago (2014-02-04 13:35:45 UTC) #11
hirono
The CQ bit was checked by hirono@chromium.org
6 years, 10 months ago (2014-02-04 15:02:45 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hirono@chromium.org/153663002/1
6 years, 10 months ago (2014-02-04 15:04:32 UTC) #13
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-04 16:10:42 UTC) #14
commit-bot: I haz the power
Retried try job too often on ios_dbg_simulator for step(s) url_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_simulator&number=120857
6 years, 10 months ago (2014-02-04 16:10:43 UTC) #15
skia-commit-bot
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-04 16:20:45 UTC) #16
hirono
The CQ bit was checked by hirono@chromium.org
6 years, 10 months ago (2014-02-05 02:38:27 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hirono@chromium.org/153663002/1
6 years, 10 months ago (2014-02-05 03:45:31 UTC) #18
commit-bot: I haz the power
6 years, 10 months ago (2014-02-05 05:42:01 UTC) #19
Message was sent while issue was closed. 
Change committed as 248864

Powered by Google App Engine
This is Rietveld 408576698