Fix memory leaks and compiler incompatibilities in wasm unittests.

Fix memory leaks and compiler incompatibilities in wasm unittests.

Fixing several memory leaks in wasm unittests.
Avoiding std::vector::data() as it isn't supported on all
compilers on the bots.
Use EXCEPT_TRUE / EXPECT_FALSE to avoid warnings on some compilers when testing boolean equality.

R=ahaas@chromium.org
BUG=

Committed: https://crrev.com/eccce9b755dd356f012e07db9da281b9d113550e
Cr-Commit-Position: refs/heads/master@{#32940}

[bradn, 2015-12-17 10:51:27]

Description was changed from

==========
Fix memory leaks an compiler incompatibilities in wasm unittests.

Fixing several memory leaks in wasm unittests.
Avoiding std::vector::data() as it isn't supported on all
compilers on the bots.

R=ahaas@chromium.org
BUG=
==========

to

==========
Fix memory leaks an compiler incompatibilities in wasm unittests.

Fixing several memory leaks in wasm unittests.
Avoiding std::vector::data() as it isn't supported on all
compilers on the bots.
Use EXCEPT_TRUE / EXPECT_FALSE to avoid warnings on some compilers when testing
boolean equality.

R=ahaas@chromium.org
BUG=
==========

[bradn, 2015-12-17 10:51:50]

Description was changed from

==========
Fix memory leaks an compiler incompatibilities in wasm unittests.

Fixing several memory leaks in wasm unittests.
Avoiding std::vector::data() as it isn't supported on all
compilers on the bots.
Use EXCEPT_TRUE / EXPECT_FALSE to avoid warnings on some compilers when testing
boolean equality.

R=ahaas@chromium.org
BUG=
==========

to

==========
Fix memory leaks and compiler incompatibilities in wasm unittests.

Fixing several memory leaks in wasm unittests.
Avoiding std::vector::data() as it isn't supported on all
compilers on the bots.
Use EXCEPT_TRUE / EXPECT_FALSE to avoid warnings on some compilers when testing
boolean equality.

R=ahaas@chromium.org
BUG=
==========

[ahaas, 2015-12-17 10:59:43]

lgtm

lgtm (one small nit)

https://codereview.chromium.org/1536603003/diff/1/test/unittests/wasm/module-...
File test/unittests/wasm/module-decoder-unittest.cc (right):

https://codereview.chromium.org/1536603003/diff/1/test/unittests/wasm/module-...
test/unittests/wasm/module-decoder-unittest.cc:137: for (int j = 0; j <
static_cast<int>(i); j++) {
nit: Why do you use the type "int" here? j is not used here, so it could have
type uint32_t and you can ignore the type cast.

[bradn, 2015-12-17 11:03:17]

https://codereview.chromium.org/1536603003/diff/1/test/unittests/wasm/module-...
File test/unittests/wasm/module-decoder-unittest.cc (right):

https://codereview.chromium.org/1536603003/diff/1/test/unittests/wasm/module-...
test/unittests/wasm/module-decoder-unittest.cc:137: for (int j = 0; j <
static_cast<int>(i); j++) {
On 2015/12/17 10:59:43, ahaas wrote:
> nit: Why do you use the type "int" here? j is not used here, so it could have
> type uint32_t and you can ignore the type cast.

Ah, good point. Mechanical blinders on.
Done.

[bradn, 2015-12-17 11:03:30]

The CQ bit was checked by bradnelson@google.com

[bradn, 2015-12-17 11:03:31]

The patchset sent to the CQ was uploaded after l-g-t-m from ahaas@chromium.org
Link to the patchset: https://codereview.chromium.org/1536603003/#ps20001
(title: "fix")

[commit-bot: I haz the power, 2015-12-17 11:03:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1536603003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1536603003/20001

[commit-bot: I haz the power, 2015-12-17 11:38:31]

Description was changed from

==========
Fix memory leaks and compiler incompatibilities in wasm unittests.

Fixing several memory leaks in wasm unittests.
Avoiding std::vector::data() as it isn't supported on all
compilers on the bots.
Use EXCEPT_TRUE / EXPECT_FALSE to avoid warnings on some compilers when testing
boolean equality.

R=ahaas@chromium.org
BUG=
==========

to

==========
Fix memory leaks and compiler incompatibilities in wasm unittests.

Fixing several memory leaks in wasm unittests.
Avoiding std::vector::data() as it isn't supported on all
compilers on the bots.
Use EXCEPT_TRUE / EXPECT_FALSE to avoid warnings on some compilers when testing
boolean equality.

R=ahaas@chromium.org
BUG=
==========

[commit-bot: I haz the power, 2015-12-17 11:38:32]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-12-17 11:38:59]

Description was changed from

==========
Fix memory leaks and compiler incompatibilities in wasm unittests.

Fixing several memory leaks in wasm unittests.
Avoiding std::vector::data() as it isn't supported on all
compilers on the bots.
Use EXCEPT_TRUE / EXPECT_FALSE to avoid warnings on some compilers when testing
boolean equality.

R=ahaas@chromium.org
BUG=
==========

to

==========
Fix memory leaks and compiler incompatibilities in wasm unittests.

Fixing several memory leaks in wasm unittests.
Avoiding std::vector::data() as it isn't supported on all
compilers on the bots.
Use EXCEPT_TRUE / EXPECT_FALSE to avoid warnings on some compilers when testing
boolean equality.

R=ahaas@chromium.org
BUG=

Committed: https://crrev.com/eccce9b755dd356f012e07db9da281b9d113550e
Cr-Commit-Position: refs/heads/master@{#32940}
==========

[commit-bot: I haz the power, 2015-12-17 11:39:00]

Patchset 2 (id:??) landed as
https://crrev.com/eccce9b755dd356f012e07db9da281b9d113550e
Cr-Commit-Position: refs/heads/master@{#32940}