Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(27)

Issue 15366004: update w3c import script to actually work :). (Closed)

Created:
7 years, 6 months ago by Dirk Pranke
Modified:
7 years, 6 months ago
Reviewers:
eseidel, ojan
CC:
blink-reviews, eae+blinkwatch
Visibility:
Public.

Description

update w3c import script to actually work :). This patch fixes an indentation problem that was keeping anything from actually importing, and incorporates most of Ojan's feedback from the initial review. R=ojan@chromium.org BUG=242330 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=150827

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -25 lines) Patch
M Tools/Scripts/webkitpy/w3c/test_converter.py View 6 chunks +12 lines, -4 lines 1 comment Download
M Tools/Scripts/webkitpy/w3c/test_importer.py View 4 chunks +11 lines, -17 lines 0 comments Download
M Tools/Scripts/webkitpy/w3c/test_parser.py View 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Dirk Pranke
https://codereview.chromium.org/15366004/diff/1/Tools/Scripts/webkitpy/w3c/test_converter.py File Tools/Scripts/webkitpy/w3c/test_converter.py (right): https://codereview.chromium.org/15366004/diff/1/Tools/Scripts/webkitpy/w3c/test_converter.py#newcode74 Tools/Scripts/webkitpy/w3c/test_converter.py:74: contents = self._filesystem.read_binary_file(filename) Note: here and below, we need ...
7 years, 6 months ago (2013-05-21 00:46:53 UTC) #1
ojan
lgtm
7 years, 6 months ago (2013-05-21 02:00:22 UTC) #2
Dirk Pranke
7 years, 6 months ago (2013-05-21 21:08:17 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r150827 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698