Issue 15366004: update w3c import script to actually work :).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15366004: update w3c import script to actually work :). (Closed)

Created:
7 years, 7 months ago by Dirk Pranke

Modified:
7 years, 7 months ago

Reviewers:
eseidel, ojan

CC:
blink-reviews, eae+blinkwatch

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

update w3c import script to actually work :). This patch fixes an indentation problem that was keeping anything from actually importing, and incorporates most of Ojan's feedback from the initial review. R=ojan@chromium.org BUG=242330 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=150827

Patch Set 1 #

Total comments: 1

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+27 lines, -25 lines)			Patch
M	Tools/Scripts/webkitpy/w3c/test_converter.py	View	6 chunks	+12 lines, -4 lines	1 comment	Download
M	Tools/Scripts/webkitpy/w3c/test_importer.py	View	4 chunks	+11 lines, -17 lines	0 comments	Download
M	Tools/Scripts/webkitpy/w3c/test_parser.py	View	3 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Dirk Pranke

https://codereview.chromium.org/15366004/diff/1/Tools/Scripts/webkitpy/w3c/test_converter.py File Tools/Scripts/webkitpy/w3c/test_converter.py (right): https://codereview.chromium.org/15366004/diff/1/Tools/Scripts/webkitpy/w3c/test_converter.py#newcode74 Tools/Scripts/webkitpy/w3c/test_converter.py:74: contents = self._filesystem.read_binary_file(filename) Note: here and below, we need ...

7 years, 7 months ago (2013-05-21 00:46:53 UTC) #1

Dirk Pranke

7 years, 7 months ago (2013-05-21 21:08:17 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r150827 (presubmit successful).

Expand Messages | Collapse Messages