Settings People Revamp: Implement Chrome Profile name/icon selection.

chrome/browser/resources/settings/settings_page/settings_router.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview
  * 'settings-router' is a simple router for settings. Its responsibilities:
  *  - Update the URL when the routing state changes.
  *  - Initialize the routing state with the initial URL.
  *  - Process and validate all routing state changes.
@@ skipping 48 matching lines @@
     },
 
     /**
      * Page titles for the currently active route. Updated by the currentRoute
      * property observer.
      * @type {{pageTitle: string, subpageTitles: Array<string>}}
      */
     currentRouteTitles: {
       notify: true,
       type: Object,
-      value: function() { return {}; },
+      value: function() {
+        return {
+          pageTitle: '',
+          subpageTitles: [],
+        };
+      },
     },
   },
 
 
  /**
   * @private
   * The 'url' property is not accessible to other elements.
   */
  routes_: [
     {
@@ skipping 24 matching lines @@
       subpage: ['search-engines'],
       subpageTitles: ['searchEnginesPageTitle'],
     },
     {
       url: '/searchEngines/advanced',
       page: 'basic',
       section: 'search',
       subpage: ['search-engines', 'search-engines-advanced'],
       subpageTitles: ['searchEnginesPageTitle', 'advancedPageTitle'],
     },
+<if expr="not chromeos">
+    {
+      url: '/manageProfile',
+      page: 'basic',
+      section: 'people',
+      subpage: ['manageProfile'],
+      subpageTitles: ['editPerson'],
+    },
+</if>
     {
       url: '/syncSetup',
       page: 'basic',
       section: 'people',
       subpage: ['sync'],
       subpageTitles: ['syncPageTitle'],
     },
 <if expr="chromeos">
     {
       url: '/accounts',
@@ skipping 119 matching lines @@
         var historicState = {
           inHistory: true,
           page: newRoute.page,
           section: newRoute.section,
           subpage: newRoute.subpage,
         };
 
         // Push the current route to the history state, so when the user
         // navigates with the browser back button, we can recall the route.
         if (oldRoute) {
-          history.pushState(historicState, null, route.url);
+          window.history.pushState(historicState, document.title, route.url);

[Dan Beam, 2016/01/07 02:41:20]

such a useless param...

[tommycli, 2016/01/07 22:08:23]

Acknowledged.

         } else {
           // For the very first route (oldRoute will be undefined), we replace
           // the existing state instead of pushing a new one. This is to allow
           // the user to use the browser back button to exit Settings entirely.
-          history.replaceState(historicState, null);
+          window.history.replaceState(historicState, document.title);
         }
 
         return;
       }
     }
 
     assertNotReached('Route not found: ' + JSON.stringify(newRoute));
   },
 });