Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(680)

Side by Side Diff: chrome/browser/resources/settings/settings_page/settings_router.js

Issue 1536593004: Settings People Revamp: Implement Chrome Profile name/icon selection. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix gn build Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @fileoverview 6 * @fileoverview
7 * 'settings-router' is a simple router for settings. Its responsibilities: 7 * 'settings-router' is a simple router for settings. Its responsibilities:
8 * - Update the URL when the routing state changes. 8 * - Update the URL when the routing state changes.
9 * - Initialize the routing state with the initial URL. 9 * - Initialize the routing state with the initial URL.
10 * - Process and validate all routing state changes. 10 * - Process and validate all routing state changes.
(...skipping 93 matching lines...) Expand 10 before | Expand all | Expand 10 after
104 subpage: ['search-engines'], 104 subpage: ['search-engines'],
105 subpageTitles: ['searchEnginesPageTitle'], 105 subpageTitles: ['searchEnginesPageTitle'],
106 }, 106 },
107 { 107 {
108 url: '/searchEngines/advanced', 108 url: '/searchEngines/advanced',
109 page: 'basic', 109 page: 'basic',
110 section: 'search', 110 section: 'search',
111 subpage: ['search-engines', 'search-engines-advanced'], 111 subpage: ['search-engines', 'search-engines-advanced'],
112 subpageTitles: ['searchEnginesPageTitle', 'advancedPageTitle'], 112 subpageTitles: ['searchEnginesPageTitle', 'advancedPageTitle'],
113 }, 113 },
114 <if expr="not chromeos">
115 {
116 url: '/manageProfile',
117 page: 'basic',
118 section: 'people',
119 subpage: ['manageProfile'],
120 subpageTitles: ['editPerson'],
121 },
122 </if>
114 { 123 {
115 url: '/syncSetup', 124 url: '/syncSetup',
116 page: 'basic', 125 page: 'basic',
117 section: 'people', 126 section: 'people',
118 subpage: ['sync'], 127 subpage: ['sync'],
119 subpageTitles: ['syncPageTitle'], 128 subpageTitles: ['syncPageTitle'],
120 }, 129 },
121 <if expr="chromeos"> 130 <if expr="chromeos">
122 { 131 {
123 url: '/accounts', 132 url: '/accounts',
(...skipping 134 matching lines...) Expand 10 before | Expand all | Expand 10 after
258 history.replaceState(historicState, null); 267 history.replaceState(historicState, null);
259 } 268 }
260 269
261 return; 270 return;
262 } 271 }
263 } 272 }
264 273
265 assertNotReached('Route not found: ' + JSON.stringify(newRoute)); 274 assertNotReached('Route not found: ' + JSON.stringify(newRoute));
266 }, 275 },
267 }); 276 });
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698